fix: make check for creating connection stricter when creating elements

Closes #1902
bpmn-io · May 4, 2023 · ce96c74 · ce96c74
1 parent 0722797
commit ce96c74
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/lib/features/rules/BpmnRules.js b/lib/features/rules/BpmnRules.js
@@ -146,7 +146,7 @@ BpmnRules.prototype.init = function() {
 
     return every(elements, function(element) {
       if (isConnection(element)) {
-        return canConnect(element.source, element.target, element);
+        return is(element, (canConnect(element.source, element.target, element) || {}).type);
       }
 
       if (element.host) {
@@ -1061,11 +1061,11 @@ function canConnectMessageFlow(source, target) {
     return false;
   }
 
-  return (
-    isMessageFlowSource(source) &&
-    isMessageFlowTarget(target) &&
-    !isSameOrganization(source, target)
-  );
+  return isMessageFlowSource(source)
+    && (!!getParent(source, 'bpmn:Participant') || is(source, 'bpmn:Participant'))
+    && isMessageFlowTarget(target)
+    && (!!getParent(target, 'bpmn:Participant') || is(target, 'bpmn:Participant'))
+    && !isSameOrganization(source, target);
 }
 
 /**