Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update test dependencies (major) #2174

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 28, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
sinon (source) ^17.0.0 -> ^18.0.0 age adoption passing confidence
sinon-chai ^3.7.0 -> ^4.0.0 age adoption passing confidence

Release Notes

sinonjs/sinon (sinon)

v18.0.0

Compare Source

This is what 17.0.2 should have been, as that contained two breaking changes. After updating
Nise we are down to one breaking change, which only affects sinon-test (which has been updated),
so most people are not affected. The legacyRoutes flag that is currently enabled in Nise by default
will at some later version be disabled. We will then issue a little migration note.

  • 01d45312
    Use Nise 6 with legacyRoutes flag enabled (Carl-Erik Kopseng)

    This should be disabled in a future Sinon version by default.

  • c618edc5
    fix #​2594: remove needless sandbox creation (Carl-Erik Kopseng)

Released by Carl-Erik Kopseng on 2024-05-15.

v17.0.2

Compare Source

  • f6dca0ba
    upgrade packages (#​2595) (Carl-Erik Kopseng)
  • 5025d001
    Avoid return and callArg* clearing each other's state (#​2593) (Carl-Erik Kopseng)
    • Partially revert "fix returns does not override call through (#​2567)"
    • revert to the old manual clearing of props
  • ed068a88
    Bump ip from 1.1.8 to 1.1.9 (#​2587) (dependabot[bot])
  • ec4d592e
    fix #​2589: avoid invoking getter as side-effect (#​2592) (Carl-Erik Kopseng)
  • 9972e1e3
    Fix typo in mocks documentation (#​2591) (Eduardo de la Cruz Palacios)
  • 52e6e4c5
    chore: prefer cache option of setup-node (Morgan Roderick)
  • 08da1235
    Bump actions/cache from 3 to 4 (dependabot[bot])
  • 404ef47e
    Bump nokogiri from 1.14.3 to 1.16.2 (dependabot[bot])
  • fd79612c
    Update Bug_report.md (Carl-Erik Kopseng)
  • 1fbc812a
    Re-add about (Carl-Erik Kopseng)
  • fc8f6c3e
    Fix formatting :clown: (Carl-Erik Kopseng)
  • c57e38ae
    Remove old template (Carl-Erik Kopseng)
  • 754bf7a9
    Update Bug_report.md (Carl-Erik Kopseng)
  • 87eed9d2
    Fix some typos at code comments (#​2581) (EliyahuMachluf)
  • cbae6997
    Link to createStubInstance util.md docs in stubs.md (#​2577) (Daniel Kaplan)
  • adcf936d
    Fix Mocha watch task by delegating to Node (#​2573) (Carl-Erik Kopseng)
  • 30ad2372
    prettier:write (Carl-Erik Kopseng)
  • 45c4d6b9
    Remove outdated info from README (#​2571) (Carl-Erik Kopseng)
  • 6c9f5c2a
    Add a notice that the Fake Timers API doc is incomplete (#​2570) (Carl-Erik Kopseng)
  • 93db3ef3
    breaking: Remove sinon.defaultConfig and related modules (#​2565) (Carl-Erik Kopseng)
    • breaking: Remove sinon.defaultConfig and related modules

    default-config and get-config are leftovers from when Sinon

    shipped with sinon.test (now the independent NPM module

    'sinon-test').

Released by Carl-Erik Kopseng on 2024-05-07.

v17.0.1

Compare Source

Released by Carl-Erik Kopseng on 2023-11-01.

chaijs/sinon-chai (sinon-chai)

v4.0.0

Compare Source

What's Changed

New Contributors

Full Changelog: chaijs/sinon-chai@3.7.0...4.0.0


Configuration

📅 Schedule: Branch creation - "after 10pm,before 5:00am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Updates a dependency label May 28, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label May 28, 2024
@nikku nikku added the backlog Queued in backlog label May 28, 2024 — with bpmn-io-tasks
@nikku nikku removed the needs review Review pending label May 28, 2024
Copy link
Contributor Author

renovate bot commented Jun 6, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/chai
npm ERR!   dev chai@"4.1.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer chai@"^5.0.0" from [email protected]
npm ERR! node_modules/sinon-chai
npm ERR!   dev sinon-chai@"^4.0.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /tmp/renovate/cache/others/npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate/cache/others/npm/_logs/2024-07-26T08_15_51_198Z-debug-0.log

@renovate renovate bot changed the title chore: update test dependencies (major) chore: update dependency sinon to v18 Jul 25, 2024
@renovate renovate bot changed the title chore: update dependency sinon to v18 chore: update test dependencies (major) Jul 25, 2024
Copy link
Contributor Author

renovate bot commented Jul 26, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@nikku
Copy link
Member

nikku commented Jul 26, 2024

@jarekdanielak This may not be an easy pick, at last. Integration with karma (our test runner) is broken by the update - c41dd8e:

image

If you want to pursue this you'd need to check for an updated integration, or we ditch karma-sinon-chai and make the globals available in another way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog dependencies Updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants