chore: migrate to eslint@9

Related to bpmn-io/internal-docs#1042
bpmn-io · Nov 5, 2024 · 0df2ffc · 0df2ffc
1 parent 265e5d5
commit 0df2ffc
Show file tree

Hide file tree

Showing 39 changed files with 109 additions and 107 deletions.
diff --git a/.eslintignore b/.eslintignore
diff --git a/.eslintrc b/.eslintrc
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -0,0 +1,47 @@
+import bpmnIoPlugin from 'eslint-plugin-bpmn-io';
+
+export default [
+  {
+    ignores: [
+      '**/lib',
+      '**/dist'
+    ]
+  },
+  ...bpmnIoPlugin.configs.browser.map(config => {
+    return {
+      ...config,
+      files: [
+        '**/src/**/*.js'
+      ]
+    };
+  }),
+  ...bpmnIoPlugin.configs.jsx.map(config => {
+    return {
+      ...config,
+      files: [
+        '**/src/**/*.js',
+        '**/test/**/*.js'
+      ]
+    };
+  }),
+  ...bpmnIoPlugin.configs.mocha.map(config => {
+    return {
+      ...config,
+      files: [
+        '**/test/**/*.js'
+      ]
+    };
+  }),
+  {
+    rules: {
+      'max-len': [ 'error', { 'code': 90 } ],
+      'no-restricted-imports': [ 'error', {
+        'patterns': [ 'dmn-js/src', 'dmn-js-*/src' ]
+      } ],
+      'react/display-name': 'off',
+      'react/no-deprecated': 'off',
+      'react/jsx-key': 'off', // TODO(@barmac): reenable and fix problems
+      'react/no-unknown-property': 'off',
+    }
+  }
+];
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -46,7 +46,7 @@
     "cross-env": "^7.0.3",
     "del-cli": "^6.0.0",
     "eslint": "^9.0.0",
-    "eslint-plugin-bpmn-io": "^2.0.0",
+    "eslint-plugin-bpmn-io": "^2.0.2",
     "karma": "^6.4.4",
     "karma-chrome-launcher": "^3.2.0",
     "karma-coverage": "^2.2.1",

diff --git a/packages/dmn-js-boxed-expression/test/.eslintrc b/packages/dmn-js-boxed-expression/test/.eslintrc
diff --git a/...ges/dmn-js-decision-table/src/features/decision-table-head/editor/components/InputCell.js b/...ges/dmn-js-decision-table/src/features/decision-table-head/editor/components/InputCell.js
@@ -86,7 +86,7 @@ export default class InputCell extends Component {
       <th
         data-col-id={ input.id }
         onDoubleClick={ this.onClick }
-        onContextmenu={ this.onContextmenu }
+        onContextMenu={ this.onContextmenu }
         className="input-cell input-editor"
         style={ { width } }
       >

diff --git a/...es/dmn-js-decision-table/src/features/decision-table-head/editor/components/OutputCell.js b/...es/dmn-js-decision-table/src/features/decision-table-head/editor/components/OutputCell.js
@@ -79,7 +79,7 @@ export default class OutputCell extends Component {
       <th
         data-col-id={ output.id }
         onDoubleClick={ this.onClick }
-        onContextmenu={ this.onContextmenu }
+        onContextMenu={ this.onContextmenu }
         className="output-cell output-editor"
         style={ { width } }
       >

diff --git a/packages/dmn-js-decision-table/src/features/simple-date-edit/Utils.js b/packages/dmn-js-decision-table/src/features/simple-date-edit/Utils.js
@@ -1,9 +1,9 @@
 const ISO_DATE_REGEX = /^\d{4}(?:-\d\d){2}$/;
 
-// eslint-disable-next-line
+
 const BETWEEN_DATE_REGEX = /^\[date\("([^"]*)"\)..date\("([^"]*)"\)\]$/;
 
-// eslint-disable-next-line
+
 const BEFORE_AFTER_DATE_REGEX = /^(<|>)\s*date\("([^"]*)"\)$/;
 
 const EXACT_DATE_REGEX = /^date\("([^"]*)"\)$/;

diff --git a/packages/dmn-js-decision-table/src/features/simple-date-time-edit/Utils.js b/packages/dmn-js-decision-table/src/features/simple-date-time-edit/Utils.js
@@ -1,12 +1,12 @@
 const ISO_DATE_REGEX = /^\d{4}(?:-\d\d){2}T(?:\d\d:){2}\d\d(?:Z|(?:[@+-][^")]+))?$/;
 
-// eslint-disable-next-line
+
 const BETWEEN_DATE_REGEX = /^\[date and time\("([^"]*)"\)..date and time\("([^"]*)"\)\]$/;
 
-// eslint-disable-next-line
+
 const BEFORE_AFTER_DATE_REGEX = /^(<|>)\s*date and time\("([^"]*)"\)$/;
 
-// eslint-disable-next-line
+
 const EXACT_DATE_REGEX = /^date and time\("([^"]*)"\)$/;
 
 const EXACT = 'exact',

diff --git a/packages/dmn-js-decision-table/test/.eslintrc b/packages/dmn-js-decision-table/test/.eslintrc
diff --git a/...ges/dmn-js-decision-table/test/spec/features/context-menu/ContextMenuCloseBehaviorSpec.js b/...ges/dmn-js-decision-table/test/spec/features/context-menu/ContextMenuCloseBehaviorSpec.js
@@ -1,4 +1,4 @@
-// eslint-disable-next-line
+ 
 import Inferno from 'inferno';
 
 import { bootstrapModeler, inject } from 'test/helper';

diff --git a/packages/dmn-js-decision-table/test/spec/features/context-menu/ContextMenuKeyboardSpec.js b/packages/dmn-js-decision-table/test/spec/features/context-menu/ContextMenuKeyboardSpec.js
@@ -1,4 +1,4 @@
-// eslint-disable-next-line
+ 
 import Inferno from 'inferno';
 
 import { bootstrapModeler, inject } from 'test/helper';

diff --git a/packages/dmn-js-decision-table/test/spec/features/context-menu/ContextMenuSpec.js b/packages/dmn-js-decision-table/test/spec/features/context-menu/ContextMenuSpec.js
@@ -1,4 +1,4 @@
-// eslint-disable-next-line
+ 
 import Inferno from 'inferno';
 
 import { bootstrapModeler, inject } from 'test/helper';

diff --git a/packages/dmn-js-decision-table/test/spec/features/copy-cut-paste/DescriptorUtilSpec.js b/packages/dmn-js-decision-table/test/spec/features/copy-cut-paste/DescriptorUtilSpec.js
@@ -177,7 +177,7 @@ describe('DescriptorUtil', function() {
     }));
 
 
-    it('should create Row descriptor', inject(function(elementRegistry) {
+    it('should create Col descriptor', inject(function(elementRegistry) {
 
       // given
       const col = elementRegistry.get('input1');

diff --git a/packages/dmn-js-decision-table/test/spec/features/drag-and-drop/DragAndDropSpec.js b/packages/dmn-js-decision-table/test/spec/features/drag-and-drop/DragAndDropSpec.js
@@ -1,4 +1,4 @@
-// eslint-disable-next-line
+ 
 import Inferno from 'inferno';
 
 /* global sinon */

diff --git a/packages/dmn-js-decision-table/test/spec/features/modeling/ModelingSpec.js b/packages/dmn-js-decision-table/test/spec/features/modeling/ModelingSpec.js
@@ -153,7 +153,7 @@ describe('Modeling', function() {
       }));
 
 
-      it('should undo', inject(function(modeling, commandStack) {
+      it('should redo', inject(function(modeling, commandStack) {
 
         // given
         var col = modeling.addCol({ type: 'dmn:OutputClause' }, 3);
@@ -250,7 +250,7 @@ describe('Modeling', function() {
       }));
 
 
-      it('should undo', inject(function(modeling, sheet, commandStack) {
+      it('should redo', inject(function(modeling, sheet, commandStack) {
 
         // given
         var table = sheet.getRoot();
@@ -301,7 +301,7 @@ describe('Modeling', function() {
       }));
 
 
-      it('should undo', inject(function(modeling, sheet, commandStack) {
+      it('should redo', inject(function(modeling, sheet, commandStack) {
 
         // given
         var table = sheet.getRoot();
@@ -356,7 +356,7 @@ describe('Modeling', function() {
       }));
 
 
-      it('should undo', inject(function(modeling, sheet, commandStack) {
+      it('should redo', inject(function(modeling, sheet, commandStack) {
 
         // given
         var table = sheet.getRoot();
@@ -407,7 +407,7 @@ describe('Modeling', function() {
       }));
 
 
-      it('should undo', inject(function(modeling, sheet, commandStack) {
+      it('should redo', inject(function(modeling, sheet, commandStack) {
 
         // given
         var table = sheet.getRoot();

diff --git a/packages/dmn-js-decision-table/test/spec/features/modeling/behavior/IdChangeBehaviorSpec.js b/packages/dmn-js-decision-table/test/spec/features/modeling/behavior/IdChangeBehaviorSpec.js
@@ -15,7 +15,7 @@ describe('IdChangeBehavior', function() {
   }));
 
 
-  it('should update IDs on decision ID change', inject(function(modeling, sheet) {
+  it('should requirements refs on decision ID change', inject(function(modeling, sheet) {
 
     // given
     const root = sheet.getRoot(),
@@ -48,7 +48,7 @@ describe('IdChangeBehavior', function() {
   }));
 
 
-  it('should update IDs on decision ID change', inject(function(modeling, sheet) {
+  it('should association refs on decision ID change', inject(function(modeling, sheet) {
 
     // given
     const root = sheet.getRoot(),

diff --git a/packages/dmn-js-decision-table/test/spec/features/simple-date-edit/SimpleDateEditSpec.js b/packages/dmn-js-decision-table/test/spec/features/simple-date-edit/SimpleDateEditSpec.js
@@ -155,7 +155,7 @@ describe('simple date edit', function() {
       // then
       expect(inputEntry7.businessObject.text).to
 
-        // eslint-disable-next-line
+         
         .equal('[date("2018-01-25")..date("2000-01-01")]');
     }));
 
@@ -175,7 +175,7 @@ describe('simple date edit', function() {
       // then
       expect(inputEntry7.businessObject.text).to
 
-        // eslint-disable-next-line
+         
         .equal('[date("2018-01-25")..date("foo")]');
     }));
 
@@ -195,7 +195,7 @@ describe('simple date edit', function() {
       // then
       expect(inputEntry7.businessObject.text).to
 
-        // eslint-disable-next-line
+         
         .equal(`[date("2018-01-25")..date("${ getSampleDate() }")]`);
     }));
   });

diff --git a/packages/dmn-js-decision-table/test/spec/features/simple-date-edit/UtilsSpec.js b/packages/dmn-js-decision-table/test/spec/features/simple-date-edit/UtilsSpec.js
@@ -96,7 +96,7 @@ describe('simple date edit - utils', function() {
       date: '2000-01-01'
     }));
 
-    // eslint-disable-next-line
+     
     it('between', expectParsed('[date("2000-01-01")..date("2000-01-02")]', {
       type: 'between',
       dates: [ '2000-01-01', '2000-01-02' ]

diff --git a/.../dmn-js-decision-table/test/spec/features/simple-date-time-edit/SimpleDateTimeEditSpec.js b/.../dmn-js-decision-table/test/spec/features/simple-date-time-edit/SimpleDateTimeEditSpec.js
@@ -175,7 +175,7 @@ describe('simple date time edit', function() {
       // then
       expect(inputEntry7.businessObject.text).to
 
-        // eslint-disable-next-line
+         
         .equal('[date and time("2018-01-25T00:00:00Z")..date and time("foo")]');
     }));
 

diff --git a/packages/dmn-js-decision-table/test/spec/features/simple-string-edit/SimpleStringEditSpec.js b/packages/dmn-js-decision-table/test/spec/features/simple-string-edit/SimpleStringEditSpec.js
@@ -169,7 +169,7 @@ describe('simple string edit', function() {
     }));
 
 
-    it('should override invalid custom value', inject(function(elementRegistry) {
+    it('should override invalid custom value (negate)', inject(function(elementRegistry) {
 
       // given
       const inputEntry3 = elementRegistry.get('inputEntry3');

diff --git a/packages/dmn-js-decision-table/test/spec/features/simple-time-edit/SimpleTimeEditSpec.js b/packages/dmn-js-decision-table/test/spec/features/simple-time-edit/SimpleTimeEditSpec.js
@@ -155,7 +155,7 @@ describe('simple time edit', function() {
       // then
       expect(inputEntry7.businessObject.text).to
 
-        // eslint-disable-next-line
+         
         .equal('[time("08:00:00Z")..time("18:00:00Z")]');
     }));
 
@@ -175,7 +175,7 @@ describe('simple time edit', function() {
       // then
       expect(inputEntry7.businessObject.text).to
 
-        // eslint-disable-next-line
+         
         .equal('[time("08:00:00Z")..time("foo")]');
     }));
 
@@ -195,7 +195,7 @@ describe('simple time edit', function() {
       // then
       expect(inputEntry7.businessObject.text).to
 
-        // eslint-disable-next-line
+         
         .equal(`[time("08:00:00Z")..time("${ getSampleTime() }")]`);
     }));
   });

diff --git a/packages/dmn-js-decision-table/test/spec/features/simple-time-edit/UtilsSpec.js b/packages/dmn-js-decision-table/test/spec/features/simple-time-edit/UtilsSpec.js
@@ -124,7 +124,7 @@ describe('simple time edit - utils', function() {
       time: '08:00:00Z'
     }));
 
-    // eslint-disable-next-line
+     
     it('between', expectParsed('[time("08:00:00Z")..time("08:00:00Z")]', {
       type: 'between',
       times: [ '08:00:00Z', '08:00:00Z' ]

diff --git a/packages/dmn-js-drd/test/.eslintrc b/packages/dmn-js-drd/test/.eslintrc
diff --git a/packages/dmn-js-drd/test/spec/features/rules/DrdRulesSpec.js b/packages/dmn-js-drd/test/spec/features/rules/DrdRulesSpec.js
@@ -232,7 +232,7 @@ describe('features/rules', function() {
   });
 
 
-  describe('move', function() {
+  describe('move decision', function() {
 
     it('decision -> definitions', inject(
       function(drdRules, elementRegistry) {

diff --git a/packages/dmn-js-literal-expression/test/.eslintrc b/packages/dmn-js-literal-expression/test/.eslintrc