Skip to content

Commit

Permalink
chore: adjust titles and labels
Browse files Browse the repository at this point in the history 
Closes #801
  • Loading branch information
@philippfromme @barmac
philippfromme authored and barmac committed Nov 29, 2023
1 parent f07dbb7 commit 8133826
Show file tree
Hide file tree
Showing 41 changed files with 129 additions and 125 deletions.
2 changes: 1 addition & 1 deletion packages/dmn-js-decision-table/src/features/add-input-output/components/AddInput.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export default class AddInput extends Component {
<div
onClick={ this.handleClick }
className="add-input actionable"
title={ this._translate('Add Input') }
title={ this._translate('Add input') }
>
<span
className="dmn-icon-plus action-icon"
Expand Down
2 changes: 1 addition & 1 deletion packages/dmn-js-decision-table/src/features/add-input-output/components/AddOutput.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export default class AddOutput extends Component {
<div
onClick={ this.handleClick }
className="add-output actionable"
title={ this._translate('Add Output') }
title={ this._translate('Add output') }
>
<span
className="dmn-icon-plus action-icon"
Expand Down
2 changes: 1 addition & 1 deletion packages/dmn-js-decision-table/src/features/add-rule/components/AddRuleFootComponent.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default class AddRuleFootComponent extends Component {
<td className="add-rule-add">
<span
className="dmn-icon-plus action-icon"
title={ this.translate('Add Rule') }>
title={ this.translate('Add rule') }>
</span>
</td>
];
Expand Down
12 changes: 6 additions & 6 deletions ...ages/dmn-js-decision-table/src/features/allowed-values/components/AllowedValuesEditing.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export default class AllowedValuesEditing extends Component {
value,
isCheckable: false,
isRemovable: true,
group: this._translate('Predefined Values')
group: this._translate('Predefined values')
};
}),
inputValue: ''
Expand Down Expand Up @@ -126,7 +126,7 @@ export default class AllowedValuesEditing extends Component {
value,
isCheckable: false,
isRemovable: true,
group: this._translate('Predefined Values')
group: this._translate('Predefined values')
};
})));

Expand Down Expand Up @@ -177,7 +177,7 @@ export default class AllowedValuesEditing extends Component {
&& !values.length
&& <div>
<label className="dms-label">
{ this._translate('Predefined Values') }
{ this._translate('Predefined values') }
</label>
<span className="placeholder">
{ this._translate('No values') }
Expand All @@ -190,13 +190,13 @@ export default class AllowedValuesEditing extends Component {
&& <p class="dms-hint">
<button type="button" className="del-values"
onClick={ this.handleRemovePredifinedValuesClick }>
{ this._translate('Clear predefined values.') }
{ this._translate('Clear predefined values') }
</button>
</p>
}

<label className="dms-label">
{ this._translate('Add Predefined Values') }
{ this._translate('Add predefined values') }
</label>

<ValidatedInput
Expand All @@ -206,7 +206,7 @@ export default class AllowedValuesEditing extends Component {
type="text"
validate={ value => {
if (!parseString(value)) {
return this._translate('Strings must be in double quotes.');
return this._translate('Strings must be in double quotes');
}
} }
value={ inputValue } />
Expand Down
42 changes: 21 additions & 21 deletions packages/dmn-js-decision-table/src/features/context-menu/ContextMenu.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -187,39 +187,39 @@ export default class ContextMenu {
<div
className="context-menu-group-entry context-menu-entry-copy-rule"
onClick={ () => handlers.copy(row) }>
{ this._translate('Copy Rule') }
{ this._translate('Copy rule') }
</div>
<div
className="context-menu-group-entry context-menu-entry-cut-rule"
onClick={ () => handlers.cut(row) }>
{ this._translate('Cut Rule') }
{ this._translate('Cut rule') }
</div>
<div
className={ `context-menu-group-entry ${ canPaste ? '' : 'disabled' } context-menu-entry-paste-rule-above` }
onClick={ () => handlers.pasteBefore(row) }>
{ this._translate('Paste Rule Above') }
{ this._translate('Paste rule above') }
</div>
<div
className={ `context-menu-group-entry ${ canPaste ? '' : 'disabled' } context-menu-entry-paste-rule-below` }
onClick={ () => handlers.pasteAfter(row) }>
{ this._translate('Paste Rule Below') }
{ this._translate('Paste rule below') }
</div>
</div>,
<div className="context-menu-group">
<div
className="context-menu-group-entry context-menu-entry-add-rule-above"
onClick={ () => handlers.addRuleAbove(row) }>
{ this._translate('Add Rule Above') }
{ this._translate('Add rule above') }
</div>
<div
className="context-menu-group-entry context-menu-entry-add-rule-below"
onClick={ () => handlers.addRuleBelow(row) }>
{ this._translate('Add Rule Below') }
{ this._translate('Add rule below') }
</div>
<div
className="context-menu-group-entry context-menu-entry-remove-rule"
onClick={ () => handlers.removeRule(row) }>
{ this._translate('Remove Rule') }
{ this._translate('Remove rule') }
</div>
</div>
);
Expand All @@ -240,39 +240,39 @@ export default class ContextMenu {
<div
className="context-menu-group-entry context-menu-entry-copy-input"
onClick={ () => handlers.copy(actualElement) }>
{ this._translate('Copy Input Column') }
{ this._translate('Copy input column') }
</div>
<div
className={ `context-menu-group-entry ${ canRemove ? '' : 'disabled' } context-menu-entry-cut-input` }
onClick={ () => handlers.cut(actualElement) }>
{ this._translate('Cut Input Column') }
{ this._translate('Cut input column') }
</div>
<div
className={ `context-menu-group-entry ${ canPaste ? '' : 'disabled' } context-menu-entry-paste-input-left` }
onClick={ () => handlers.pasteBefore(actualElement) }>
{ this._translate('Paste Input Column Left') }
{ this._translate('Paste input column left') }
</div>
<div
className={ `context-menu-group-entry ${ canPaste ? '' : 'disabled' } context-menu-entry-paste-input-right` }
onClick={ () => handlers.pasteAfter(actualElement) }>
{ this._translate('Paste Input Column Right') }
{ this._translate('Paste input column right') }
</div>
</div>,
<div className="context-menu-group">
<div
className="context-menu-group-entry context-menu-entry-add-input-left"
onClick={ () => handlers.addInputLeft(actualElement) }>
{ this._translate('Add Input Column Left') }
{ this._translate('Add input column left') }
</div>
<div
className="context-menu-group-entry context-menu-entry-add-input-right"
onClick={ () => handlers.addInputRight(actualElement) }>
{ this._translate('Add Input Column Right') }
{ this._translate('Add input column right') }
</div>
<div
className={ `context-menu-group-entry ${ canRemove ? '' : 'disabled' } context-menu-entry-remove-input` }
onClick={ () => handlers.removeInput(actualElement) }>
{ this._translate('Remove Input Column') }
{ this._translate('Remove input column') }
</div>
</div>
);
Expand All @@ -293,39 +293,39 @@ export default class ContextMenu {
<div
className="context-menu-group-entry context-menu-entry-copy-output"
onClick={ () => handlers.copy(actualElement) }>
{ this._translate('Copy Output Column') }
{ this._translate('Copy output column') }
</div>
<div
className={ `context-menu-group-entry ${ canRemove ? '' : 'disabled' } context-menu-entry-cut-output` }
onClick={ () => handlers.cut(actualElement) }>
{ this._translate('Cut Output Column') }
{ this._translate('Cut output column') }
</div>
<div
className={ `context-menu-group-entry ${ canPaste ? '' : 'disabled' } context-menu-entry-paste-output-left` }
onClick={ () => handlers.pasteBefore(actualElement) }>
{ this._translate('Paste Output Column Left') }
{ this._translate('Paste output column left') }
</div>
<div
className={ `context-menu-group-entry ${ canPaste ? '' : 'disabled' } context-menu-entry-paste-output-right` }
onClick={ () => handlers.pasteAfter(actualElement) }>
{ this._translate('Paste Output Column Right') }
{ this._translate('Paste output column right') }
</div>
</div>,
<div className="context-menu-group">
<div
className="context-menu-group-entry context-menu-entry-add-output-left"
onClick={ () => handlers.addOutputLeft(actualElement) }>
{ this._translate('Add Output Column Left') }
{ this._translate('Add output column left') }
</div>
<div
className="context-menu-group-entry context-menu-entry-add-output-right"
onClick={ () => handlers.addOutputRight(actualElement) }>
{ this._translate('Add Output Column Right') }
{ this._translate('Add output column right') }
</div>
<div
className={ `context-menu-group-entry ${ canRemove ? '' : 'disabled' } context-menu-entry-remove-output` }
onClick={ () => handlers.removeOutput(actualElement) }>
{ this._translate('Remove Output Column') }
{ this._translate('Remove output column') }
</div>
</div>
);
Expand Down
2 changes: 1 addition & 1 deletion packages/dmn-js-decision-table/src/features/create-inputs/components/CreateInputCell.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default class CreateInputsCell extends Component {
<td
className="input-cell create-inputs"
onClick={ this.onClick }
title={ this.translate('Add Input') }>-</td>
title={ this.translate('Add input') }>-</td>
);
}
}
Expand Down
4 changes: 2 additions & 2 deletions ...ages/dmn-js-decision-table/src/features/create-inputs/components/CreateInputHeaderCell.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ export default class CreateInputsHeaderCell extends Component {
<th
className="input-cell create-inputs header actionable"
onClick={ this.onClick }
title={ this.translate('Add Input') }>
title={ this.translate('Add input') }>
{ this.translate('Input') } <span
className="add-input dmn-icon-plus action-icon"
title={ this.translate('Add Input') }
title={ this.translate('Add input') }
></span>
</th>
);
Expand Down
2 changes: 1 addition & 1 deletion ...decision-table/src/features/decision-rules/components/DecisionRulesCellEditorComponent.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ class TableCellEditor extends Component {
<span
className="dms-badge dmn-expression-language"
title={ this._translate(
'Expression Language = {expressionLanguageLabel}',
'Expression language: {expressionLanguageLabel}',
{ expressionLanguageLabel }
) }>
<span class="dms-badge-icon dmn-icon-file-code"></span>
Expand Down
16 changes: 8 additions & 8 deletions ...es/dmn-js-decision-table/src/features/decision-table-head/components/DecisionTableHead.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -145,13 +145,13 @@ function DefaultInputHeaderCell(props, context) {
label ? (
<div
className="input-label"
title={ translate('Input Label: ') + label }>
title={ translate('Input label: ') + label }>
{ label }
</div>
) : (
<div
className="input-expression"
title={ translate('Input Expression: ') + inputExpression.text }>
title={ translate('Input expression: ') + inputExpression.text }>
{ inputExpression.text }
</div>
)
Expand All @@ -160,8 +160,8 @@ function DefaultInputHeaderCell(props, context) {
<div
className="input-variable"
title={
inputValues && inputValues.text ? translate('Input Values') :
translate('Input Type')
inputValues && inputValues.text ? translate('Input values') :
translate('Input type')
}
>
{ inputValues && inputValues.text || inputExpression.typeRef }
Expand Down Expand Up @@ -199,13 +199,13 @@ function DefaultOutputHeaderCell(props, context) {

{
label ? (
<div className="output-label" title={ translate('Output Label') }>
<div className="output-label" title={ translate('Output label') }>
{ label }
</div>
) : (
<div
className="output-name"
title={ translate('Output Name') }>
title={ translate('Output name') }>
{ name }
</div>
)
Expand All @@ -214,8 +214,8 @@ function DefaultOutputHeaderCell(props, context) {
<div
className="output-variable"
title={
outputValues && outputValues.text ? translate('Output Values') :
translate('Output Type')
outputValues && outputValues.text ? translate('Output values') :
translate('Output type')
}
>
{ outputValues && outputValues.text || typeRef }
Expand Down
8 changes: 4 additions & 4 deletions ...ges/dmn-js-decision-table/src/features/decision-table-head/editor/components/InputCell.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -112,13 +112,13 @@ export default class InputCell extends Component {
label ? (
<div
className="input-label"
title={ this._translate('Input Label: ') + label }>
title={ this._translate('Input label: ') + label }>
{ label }
</div>
) : (
<div
className="input-expression"
title={ this._translate('Input Expression: ') + inputExpression.text }>
title={ this._translate('Input expression: ') + inputExpression.text }>
{ inputExpression.text }
</div>
)
Expand All @@ -127,8 +127,8 @@ export default class InputCell extends Component {
<div
className="input-variable"
title={
inputValues && inputValues.text ? this._translate('Input Values') :
this._translate('Input Type')
inputValues && inputValues.text ? this._translate('Input values') :
this._translate('Input type')
}
>
{ inputValues && inputValues.text ||
Expand Down
2 changes: 1 addition & 1 deletion ...s/dmn-js-decision-table/src/features/decision-table-head/editor/components/InputEditor.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export default class InputEditor extends Component {
</label>

<ExpressionEditor
placeholder={ this.translate('enter expression') }
placeholder={ this.translate('Enter expression') }
className={
[
'ref-text',
Expand Down
8 changes: 4 additions & 4 deletions ...es/dmn-js-decision-table/src/features/decision-table-head/editor/components/OutputCell.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,13 @@ export default class OutputCell extends Component {
label ? (
<div
className="output-label"
title={ this._translate('Output Label: ') + label }>
title={ this._translate('Output label: ') + label }>
{ label }
</div>
) : (
<div
className="output-name"
title={ this._translate('Output Name: ') + name }>
title={ this._translate('Output name: ') + name }>
{ name }
</div>
)
Expand All @@ -120,8 +120,8 @@ export default class OutputCell extends Component {
<div
className="output-variable"
title={
outputValues && outputValues.text ? this._translate('Output Values') :
this._translate('Output Type')
outputValues && outputValues.text ? this._translate('Output values') :
this._translate('Output type')
}
>
{ outputValues && outputValues.text || this._translate(typeRef || '') }
Expand Down
2 changes: 1 addition & 1 deletion .../dmn-js-decision-table/src/features/decision-table-head/editor/components/OutputEditor.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export default class OutputEditor extends Component {
<div className="dms-form-control">
<label className="dms-label">
{
this.translate('Output Name')
this.translate('Output name')
}
</label>

Expand Down
2 changes: 1 addition & 1 deletion ...ble/src/features/decision-table-properties/components/DecisionTablePropertiesComponent.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default class DecisionTablePropertiesComponent extends Component {
return (
<div className="decision-table-properties">
<div className="decision-table-name" title={
this._translate('Decision Name: ') + name }>
this._translate('Decision name: ') + name }>
{ name }
</div>
<div className="decision-table-header-separator" />
Expand Down
2 changes: 1 addition & 1 deletion ...c/features/decision-table-properties/components/DecisionTablePropertiesEditorComponent.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class DecisionTableName extends EditableComponent {
className={ className }
data-element-id={ this.props.elementId }
data-coords={ this.props.coords }
title={ this._translate('Decision Name: ') + name }
title={ this._translate('Decision name: ') + name }
>
{ this.getEditor() }
</div>
Expand Down
Loading

0 comments on commit 8133826

Please sign in to comment.