WIP: migrate to eslint@9

bpmn-io · Oct 11, 2024 · 9c1e406 · 9c1e406
1 parent e32332d
commit 9c1e406
Show file tree

Hide file tree

Showing 25 changed files with 94 additions and 50 deletions.
diff --git a/.eslintignore b/.eslintignore
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -0,0 +1,43 @@
+import bpmnIoPlugin from 'eslint-plugin-bpmn-io';
+
+export default [
+  {
+    ignores: [
+      '**/lib',
+      '**/dist'
+    ]
+  },
+  ...bpmnIoPlugin.configs.browser.map(config => {
+    return {
+      ...config,
+      files: [
+        '**/src/**/*.js'
+      ]
+    };
+  }),
+  ...bpmnIoPlugin.configs.jsx.map(config => {
+    return {
+      ...config,
+      files: [
+        '**/src/**/*.js',
+        '**/test/**/*.js'
+      ]
+    };
+  }),
+  ...bpmnIoPlugin.configs.mocha.map(config => {
+    return {
+      ...config,
+      files: [
+        '**/test/**/*.js'
+      ]
+    };
+  }),
+  {
+    rules: {
+      'max-len': [ 2, { 'code': 90 } ],
+      'no-restricted-imports': [ 2, {
+        'patterns': [ 'dmn-js/src', 'dmn-js-*/src' ]
+      } ]
+    }
+  }
+];
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -46,7 +46,7 @@
     "cross-env": "^7.0.3",
     "del-cli": "^6.0.0",
     "eslint": "^9.0.0",
-    "eslint-plugin-bpmn-io": "^2.0.0",
+    "eslint-plugin-bpmn-io": "^2.0.2",
     "karma": "^6.4.4",
     "karma-chrome-launcher": "^3.2.0",
     "karma-coverage": "^2.2.1",

diff --git a/...ges/dmn-js-decision-table/src/features/decision-table-head/editor/components/InputCell.js b/...ges/dmn-js-decision-table/src/features/decision-table-head/editor/components/InputCell.js
@@ -86,7 +86,7 @@ export default class InputCell extends Component {
       <th
         data-col-id={ input.id }
         onDoubleClick={ this.onClick }
-        onContextmenu={ this.onContextmenu }
+        onContextMenu={ this.onContextmenu }
         className="input-cell input-editor"
         style={ { width } }
       >

diff --git a/...es/dmn-js-decision-table/src/features/decision-table-head/editor/components/OutputCell.js b/...es/dmn-js-decision-table/src/features/decision-table-head/editor/components/OutputCell.js
@@ -79,7 +79,7 @@ export default class OutputCell extends Component {
       <th
         data-col-id={ output.id }
         onDoubleClick={ this.onClick }
-        onContextmenu={ this.onContextmenu }
+        onContextMenu={ this.onContextmenu }
         className="output-cell output-editor"
         style={ { width } }
       >

diff --git a/packages/dmn-js-decision-table/src/features/simple-date-edit/Utils.js b/packages/dmn-js-decision-table/src/features/simple-date-edit/Utils.js
@@ -1,9 +1,9 @@
 const ISO_DATE_REGEX = /^\d{4}(?:-\d\d){2}$/;
 
-// eslint-disable-next-line
+
 const BETWEEN_DATE_REGEX = /^\[date\("([^"]*)"\)..date\("([^"]*)"\)\]$/;
 
-// eslint-disable-next-line
+
 const BEFORE_AFTER_DATE_REGEX = /^(<|>)\s*date\("([^"]*)"\)$/;
 
 const EXACT_DATE_REGEX = /^date\("([^"]*)"\)$/;

diff --git a/packages/dmn-js-decision-table/src/features/simple-date-time-edit/Utils.js b/packages/dmn-js-decision-table/src/features/simple-date-time-edit/Utils.js
@@ -1,12 +1,12 @@
 const ISO_DATE_REGEX = /^\d{4}(?:-\d\d){2}T(?:\d\d:){2}\d\d(?:Z|(?:[@+-][^")]+))?$/;
 
-// eslint-disable-next-line
+
 const BETWEEN_DATE_REGEX = /^\[date and time\("([^"]*)"\)..date and time\("([^"]*)"\)\]$/;
 
-// eslint-disable-next-line
+
 const BEFORE_AFTER_DATE_REGEX = /^(<|>)\s*date and time\("([^"]*)"\)$/;
 
-// eslint-disable-next-line
+
 const EXACT_DATE_REGEX = /^date and time\("([^"]*)"\)$/;
 
 const EXACT = 'exact',

diff --git a/...ges/dmn-js-decision-table/test/spec/features/context-menu/ContextMenuCloseBehaviorSpec.js b/...ges/dmn-js-decision-table/test/spec/features/context-menu/ContextMenuCloseBehaviorSpec.js
@@ -1,4 +1,4 @@
-// eslint-disable-next-line
+ 
 import Inferno from 'inferno';
 
 import { bootstrapModeler, inject } from 'test/helper';

diff --git a/packages/dmn-js-decision-table/test/spec/features/context-menu/ContextMenuKeyboardSpec.js b/packages/dmn-js-decision-table/test/spec/features/context-menu/ContextMenuKeyboardSpec.js
@@ -1,4 +1,4 @@
-// eslint-disable-next-line
+ 
 import Inferno from 'inferno';
 
 import { bootstrapModeler, inject } from 'test/helper';

diff --git a/packages/dmn-js-decision-table/test/spec/features/context-menu/ContextMenuSpec.js b/packages/dmn-js-decision-table/test/spec/features/context-menu/ContextMenuSpec.js
@@ -1,4 +1,4 @@
-// eslint-disable-next-line
+ 
 import Inferno from 'inferno';
 
 import { bootstrapModeler, inject } from 'test/helper';

diff --git a/packages/dmn-js-decision-table/test/spec/features/drag-and-drop/DragAndDropSpec.js b/packages/dmn-js-decision-table/test/spec/features/drag-and-drop/DragAndDropSpec.js
@@ -1,4 +1,4 @@
-// eslint-disable-next-line
+ 
 import Inferno from 'inferno';
 
 /* global sinon */

diff --git a/packages/dmn-js-decision-table/test/spec/features/simple-date-edit/SimpleDateEditSpec.js b/packages/dmn-js-decision-table/test/spec/features/simple-date-edit/SimpleDateEditSpec.js
@@ -155,7 +155,7 @@ describe('simple date edit', function() {
       // then
       expect(inputEntry7.businessObject.text).to
 
-        // eslint-disable-next-line
+         
         .equal('[date("2018-01-25")..date("2000-01-01")]');
     }));
 
@@ -175,7 +175,7 @@ describe('simple date edit', function() {
       // then
       expect(inputEntry7.businessObject.text).to
 
-        // eslint-disable-next-line
+         
         .equal('[date("2018-01-25")..date("foo")]');
     }));
 
@@ -195,7 +195,7 @@ describe('simple date edit', function() {
       // then
       expect(inputEntry7.businessObject.text).to
 
-        // eslint-disable-next-line
+         
         .equal(`[date("2018-01-25")..date("${ getSampleDate() }")]`);
     }));
   });

diff --git a/packages/dmn-js-decision-table/test/spec/features/simple-date-edit/UtilsSpec.js b/packages/dmn-js-decision-table/test/spec/features/simple-date-edit/UtilsSpec.js
@@ -96,7 +96,7 @@ describe('simple date edit - utils', function() {
       date: '2000-01-01'
     }));
 
-    // eslint-disable-next-line
+     
     it('between', expectParsed('[date("2000-01-01")..date("2000-01-02")]', {
       type: 'between',
       dates: [ '2000-01-01', '2000-01-02' ]

diff --git a/.../dmn-js-decision-table/test/spec/features/simple-date-time-edit/SimpleDateTimeEditSpec.js b/.../dmn-js-decision-table/test/spec/features/simple-date-time-edit/SimpleDateTimeEditSpec.js
@@ -175,7 +175,7 @@ describe('simple date time edit', function() {
       // then
       expect(inputEntry7.businessObject.text).to
 
-        // eslint-disable-next-line
+         
         .equal('[date and time("2018-01-25T00:00:00Z")..date and time("foo")]');
     }));
 

diff --git a/packages/dmn-js-decision-table/test/spec/features/simple-time-edit/SimpleTimeEditSpec.js b/packages/dmn-js-decision-table/test/spec/features/simple-time-edit/SimpleTimeEditSpec.js
@@ -155,7 +155,7 @@ describe('simple time edit', function() {
       // then
       expect(inputEntry7.businessObject.text).to
 
-        // eslint-disable-next-line
+         
         .equal('[time("08:00:00Z")..time("18:00:00Z")]');
     }));
 
@@ -175,7 +175,7 @@ describe('simple time edit', function() {
       // then
       expect(inputEntry7.businessObject.text).to
 
-        // eslint-disable-next-line
+         
         .equal('[time("08:00:00Z")..time("foo")]');
     }));
 
@@ -195,7 +195,7 @@ describe('simple time edit', function() {
       // then
       expect(inputEntry7.businessObject.text).to
 
-        // eslint-disable-next-line
+         
         .equal(`[time("08:00:00Z")..time("${ getSampleTime() }")]`);
     }));
   });

diff --git a/packages/dmn-js-decision-table/test/spec/features/simple-time-edit/UtilsSpec.js b/packages/dmn-js-decision-table/test/spec/features/simple-time-edit/UtilsSpec.js
@@ -124,7 +124,7 @@ describe('simple time edit - utils', function() {
       time: '08:00:00Z'
     }));
 
-    // eslint-disable-next-line
+     
     it('between', expectParsed('[time("08:00:00Z")..time("08:00:00Z")]', {
       type: 'between',
       times: [ '08:00:00Z', '08:00:00Z' ]

diff --git a/packages/dmn-js-shared/src/components/ContentEditable.js b/packages/dmn-js-shared/src/components/ContentEditable.js
@@ -240,14 +240,14 @@ export default class ContentEditable extends Component {
         tabIndex="0"
         className={ this.getClassName() }
         contentEditable="true"
-        spellcheck="false"
+        spellCheck="false"
         data-placeholder={ placeholder || '' }
         onInput={ this.onInput }
-        onKeypress={ this.onKeypress }
+        onKeyPress={ this.onKeypress }
         onPaste={ this.onPaste }
         onFocus={ this.onFocus }
         onBlur={ this.onBlur }
-        onKeydown={ this.onKeydown }
+        onKeyDown={ this.onKeydown }
         ref={ node => this.node = node }
         dangerouslySetInnerHTML={ { __html: value } }></div>
     );

diff --git a/packages/dmn-js-shared/src/components/Input.js b/packages/dmn-js-shared/src/components/Input.js
@@ -87,7 +87,7 @@ export default class Input extends Component {
         onInput={ this.onInput }
         onKeyDown={ this.onKeyDown }
         onKeyUp={ this.onKeyUp }
-        spellcheck="false"
+        spellCheck="false"
         type={ type || 'text' }
         value={ value }
         id={ id } />

diff --git a/packages/dmn-js-shared/src/components/InputSelect.js b/packages/dmn-js-shared/src/components/InputSelect.js
@@ -344,7 +344,7 @@ export default class InputSelect extends Component {
               <div
                 aria-label={ inputLabel }
                 className="dms-input"
-                tabindex="0"
+                tabIndex="0"
                 onKeyDown={ this.onKeyDown }
                 ref={ node => this.inputNode = node }
               >{ label }</div>
@@ -354,7 +354,7 @@ export default class InputSelect extends Component {
                 className="dms-input"
                 onInput={ this.onInput }
                 onKeyDown={ this.onKeyDown }
-                spellcheck="false"
+                spellCheck="false"
                 ref={ node => this.inputNode = node }
                 type="text"
                 value={ value }

diff --git a/packages/dmn-js-shared/src/components/ValidatedInput.js b/packages/dmn-js-shared/src/components/ValidatedInput.js
@@ -1,6 +1,6 @@
 import { Component } from 'inferno';
 
-// eslint-disable-next-line
+
 import Input from './Input';
 
 /**

diff --git a/packages/dmn-js-shared/test/spec/base/ManagerSpec.js b/packages/dmn-js-shared/test/spec/base/ManagerSpec.js
@@ -593,7 +593,7 @@ describe('Manager', function() {
     });
 
 
-    it('should emit <import.done> when diagram clear fails', async () => {
+    it('should emit <import.done> when diagram clear fails', async function() {
 
       // given
       class ClearErrorView extends TestView {

diff --git a/packages/dmn-js-shared/test/spec/components/ValidatedInputSpec.js b/packages/dmn-js-shared/test/spec/components/ValidatedInputSpec.js
@@ -10,7 +10,7 @@ import {
 
 import { triggerInputEvent } from 'test/util/EventUtil';
 
-// eslint-disable-next-line
+ 
 import ValidatedInput from 'src/components/ValidatedInput';
 
 

diff --git a/packages/dmn-js-shared/test/spec/features/data-types/DataTypesSpec.js b/packages/dmn-js-shared/test/spec/features/data-types/DataTypesSpec.js
@@ -18,7 +18,7 @@ const DEFAULT_DATA_TYPES = [
 
 describe('DataTypes', function() {
 
-  it('should set default data types', () => {
+  it('should set default data types', function() {
 
     // given
     const dataTypes = createDataTypes();
@@ -31,7 +31,7 @@ describe('DataTypes', function() {
   });
 
 
-  it('should read data types from config', () => {
+  it('should read data types from config', function() {
 
     // given
     const dataTypes = createDataTypes({

diff --git a/packages/dmn-js-shared/test/spec/features/expression-languages/ExpressionLanguagesSpec.js b/packages/dmn-js-shared/test/spec/features/expression-languages/ExpressionLanguagesSpec.js
@@ -31,9 +31,9 @@ const CUSTOM_OPTIONS = [ {
 
 describe('ExpressionLanguages', function() {
 
-  describe('defaults', () => {
+  describe('defaults', function() {
 
-    it('should set default editor expression language to FEEL', () => {
+    it('should set default editor expression language to FEEL', function() {
 
       // given
       const expressionLanguages = createExpressionLanguages();
@@ -49,7 +49,7 @@ describe('ExpressionLanguages', function() {
     });
 
 
-    it('should set default input cell expression language to FEEL', () => {
+    it('should set default input cell expression language to FEEL', function() {
 
       // given
       const expressionLanguages = createExpressionLanguages();
@@ -65,7 +65,7 @@ describe('ExpressionLanguages', function() {
     });
 
 
-    it('should use user provided defaults', () => {
+    it('should use user provided defaults', function() {
 
       // given
       const expressionLanguages = createExpressionLanguages({
@@ -94,7 +94,7 @@ describe('ExpressionLanguages', function() {
     });
 
 
-    it('should support legacy defaults', () => {
+    it('should support legacy defaults', function() {
 
       // given
       const expressionLanguages = createExpressionLanguages({
@@ -122,9 +122,9 @@ describe('ExpressionLanguages', function() {
   });
 
 
-  describe('options', () => {
+  describe('options', function() {
 
-    it('should correctly set default options', () => {
+    it('should correctly set default options', function() {
 
       // given
       const expressionLanguages = createExpressionLanguages();
@@ -137,7 +137,7 @@ describe('ExpressionLanguages', function() {
     });
 
 
-    it('should use provided options', () => {
+    it('should use provided options', function() {
 
       // given
       const expressionLanguages = createExpressionLanguages({