test: fix flaky test in literal expression

bpmn-io · Oct 16, 2024 · 9f72c23 · 9f72c23
1 parent e9227ec
commit 9f72c23
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/dmn-js-literal-expression/package.json b/packages/dmn-js-literal-expression/package.json
@@ -26,6 +26,7 @@
     "literal expression"
   ],
   "devDependencies": {
+    "@testing-library/dom": "^10.4.0",
     "dmn-font": "^0.6.2",
     "inferno-test-utils": "~5.6.2"
   },

diff --git a/packages/dmn-js-literal-expression/test/spec/features/textarea/TextareaEditorSpec.js b/packages/dmn-js-literal-expression/test/spec/features/textarea/TextareaEditorSpec.js
@@ -2,6 +2,8 @@
 
 import { bootstrapModeler, inject } from 'test/helper';
 
+import { fireEvent, waitFor } from '@testing-library/dom';
+
 import { query as domQuery } from 'min-dom';
 
 import { queryEditor } from 'dmn-js-shared/test/util/EditorUtil';
@@ -71,10 +73,12 @@ describe('textarea editor', function() {
     await act(() => editor.focus());
 
     // when
-    await changeInput(document.activeElement, 'foo');
+    changeInput(document.activeElement, 'foo');
 
     // then
-    expect(viewer.getDecision().decisionLogic.text).to.equal('foo');
+    await waitFor(() => {
+      expect(viewer.getDecision().decisionLogic.text).to.equal('foo');
+    });
   }));
 
 
@@ -109,10 +113,12 @@ describe('textarea editor', function() {
       await changeFocus(editor);
 
       // when
-      await changeInput(document.activeElement, 'Var');
+      changeInput(document.activeElement, 'Var');
 
       // then
-      expect(getVariablesSpy).to.have.been.called;
+      await waitFor(() => {
+        expect(getVariablesSpy).to.have.been.called;
+      });
     });
   });
 
@@ -124,8 +130,8 @@ describe('textarea editor', function() {
  * @param {HTMLElement} input
  * @param {string} value
  */
-async function changeInput(input, value) {
-  await act(() => input.textContent = value);
+function changeInput(input, value) {
+  fireEvent.change(input, { target: { textContent: value } });
 }
 
 async function changeFocus(editor) {