Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed FEEL editor in input expression #770

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Embed FEEL editor in input expression #770

merged 2 commits into from
Aug 14, 2023

Conversation

barmac
Copy link
Member

@barmac barmac commented Aug 7, 2023

Screen.Recording.2023-08-07.at.16.28.24.mov

Closes #768

@barmac barmac requested review from a team, philippfromme and smbea and removed request for a team August 7, 2023 14:28
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Aug 7, 2023
@barmac barmac requested a review from marstamm August 11, 2023 15:47
philippfromme
philippfromme approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's follow up on Escape blurs the input but does not close popup. Everything else looks good and is working. ✅

@CatalinaMoisuc
Copy link
Member

Let's follow up on Escape blurs the input but does not close popup. Everything else looks good and is working. ✅

@philippfromme does this mean that this PR is mergeable as is and we can follow up with Escape blurs the input but does not close popup in another PR? If that is true, can you open a new issue for @barmac for when he is back (in September) and merge this PR so it doesn't stay hanging until then? Thanks!

@philippfromme philippfromme merged commit 3edc242 into develop Aug 14, 2023
5 checks passed
@philippfromme philippfromme deleted the 768-embed-feel-editor-in-input-expression branch August 14, 2023 13:23
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 14, 2023
@philippfromme philippfromme mentioned this pull request Aug 14, 2023
Open
@philippfromme
Copy link
Contributor

Follow-up issue for not closing context menu on Esc: #771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme approved these changes

@smbea smbea Awaiting requested review from smbea smbea was automatically assigned from bpmn-io/modeling-dev

@marstamm marstamm Awaiting requested review from marstamm

Assignees

@barmac barmac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embed FEEL editor in Input expressions in the table header
3 participants
@barmac @CatalinaMoisuc @philippfromme