Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display FEEL autocomplete suggestions in correct position #782

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

barmac
Copy link
Member

@barmac barmac commented Sep 25, 2023

Related to camunda/camunda-modeler#3881 (comment)

Learning: transforms break computed positions in autocomplete, so we should try to avoid it if possible.

@barmac barmac requested review from marstamm, a team and philippfromme and removed request for a team September 25, 2023 12:40
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 25, 2023
@barmac barmac changed the base branch from develop to master September 25, 2023 12:59
@barmac
Copy link
Member Author

barmac commented Sep 25, 2023

Big table:

Screen.Recording.2023-09-25.at.15.09.31.mov

@barmac barmac merged commit 776a4d9 into master Sep 25, 2023
8 checks passed
@barmac barmac deleted the attach-powered-by-to-decision-table-container branch September 25, 2023 13:10
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 25, 2023
@nikku
Copy link
Member

nikku commented Sep 25, 2023

So it works great with it! ⭐

barmac added a commit that referenced this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants