Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing translations #794

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: add missing translations #794

merged 1 commit into from
Oct 23, 2023

Conversation

kevin-fong
Copy link
Contributor

Hello everyone. I'm not a JavaScript developer and this is my first time working with node.js. The changes in this pr pass npm run all and are visible in npm run start:translate. Please let me know if you see any issues.


Three dmn-js ui labels are not translatable. This pr makes them translatable.

Closes #793

Added Translations

Decision Table

  • Decision Editor
    • "Add Rule"
    • "Move rule"

Literal Expression

  • Literal Expression Editor
    • "name"

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2023

CLA assistant check
All committers have signed the CLA.

@barmac
Copy link
Member

barmac commented Oct 23, 2023

Thank you! The PR looks correct so I am merging it, and will release changes soon.

@barmac barmac merged commit eab304d into bpmn-io:develop Oct 23, 2023
7 checks passed
@barmac
Copy link
Member

barmac commented Oct 23, 2023

FYI released as v14.6.0

@kevin-fong
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certain dmn-js ui labels are not translatable
3 participants