Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom selection outlines #800

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Custom selection outlines #800

merged 2 commits into from
Nov 3, 2023

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Nov 1, 2023

Closes #799

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Nov 1, 2023
@smbea smbea force-pushed the selection-outlines branch from 0ddfbfe to 3c7dc1a Compare November 1, 2023 13:56
@smbea smbea marked this pull request as ready for review November 1, 2023 14:28
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 1, 2023
@smbea smbea requested review from a team, philippfromme and marstamm and removed request for a team November 1, 2023 14:28
@barmac barmac self-requested a review November 2, 2023 13:44
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This problem needs to be fixed here too: bpmn-io/bpmn-js#2002

image

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Nov 2, 2023
@barmac
Copy link
Member

barmac commented Nov 2, 2023

BTW the new selection outlines for the DMN elements look awesome.

@barmac
Copy link
Member

barmac commented Nov 2, 2023

The "funny rectangular" problem can be reproduced here as well:

Screen.Recording.2023-11-02.at.14.57.40.mov

@smbea smbea force-pushed the selection-outlines branch from 3c7dc1a to 4e7b477 Compare November 3, 2023 14:09
@barmac barmac merged commit a87c1d2 into develop Nov 3, 2023
5 checks passed
@barmac barmac deleted the selection-outlines branch November 3, 2023 14:36
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selection lines follow element shape
2 participants