Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make literal expression variables table styles explicit #907

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

jarekdanielak
Copy link
Contributor

Related to camunda/camunda-modeler#4550

Proposed Changes

Add explicit styles for the table and make them into a class to prevent being overridden.

Possible a topic for further discussion as described here: bpmn-io/variable-outline#4

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Oct 14, 2024
@jarekdanielak jarekdanielak requested review from nikku, philippfromme and barmac and removed request for philippfromme October 14, 2024 18:33
@jarekdanielak jarekdanielak merged commit 3f271ec into main Oct 18, 2024
8 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 18, 2024
@jarekdanielak jarekdanielak deleted the dmn-table-fix branch October 18, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants