Added bucket operations to supported functionality #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradenmacdonald
approved these changes
Feb 8, 2024
| public async makeBucket(bucketName: string): Promise<void> { | ||
| await this.makeRequest({ | ||
| method: "PUT", | ||
| bucketName: this.getBucketName({ bucketName }), |
There was a problem hiding this comment.
Since we're calling this.getBucketName, we could specify that the bucketName: string parameter is optional, and if it's undefined it would fall back to this.defaultBucket. But I guess that even if we're not using that functionality here, this.getBucketName() is still serving a useful purpose of validating the bucket name.
There was a problem hiding this comment.
At first, I thought about allowing the bucketName to be optional, but I ultimately concluded that emphasizing clarity by requiring it explicitly was the best approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new functionalities to the client. The added methods allow for checking if a bucket exists, creating a new bucket, and removing an existing bucket in the client. These methods are
bucketExists,makeBucket, andremoveBucketrespectively.