Adds unmountComponentAtNode top level api. #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revanthmahesh
force-pushed
the
unmountComponentAtNode
branch
5 times, most recently
from
97764ff
to
c31684a
Compare
revanthmahesh
force-pushed
the
unmountComponentAtNode
branch
2 times, most recently
from
adaeb53
to
599dcc3
Compare
…nder is called again with same component - Fixed state batching issue. - Call rerender on batched state change only if there are unCommitted state.
…n jest in debug mode.
- Conditionally rendering Foo to test componentWIllUnmount()
…pport jest global variables. - Deleted commented test for code which are deprecated or legacy API.
- Added some comments on the code
To compare props and state of pure components
Add default prop maxLength to TODO list example Don't add to item to TodoList if text not present
- Run eslint --fix on all file after the update.
- Added jest config - Removed unused code on tearDown - Removed unused example
revanthmahesh
force-pushed
the
unmountComponentAtNode
branch
from
0be5d05
to
1a521b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #23
unmountComponentAtNode( container ): if container has a brahmosNode, it will be tear down and returns true, else return false.