feat(devtool): add react devtool support [WIP] #68
Conversation
| console.error(e); | ||
| } | ||
| }; | ||
| } |
There was a problem hiding this comment.
Sure probably we need to add prettier, husky
| @@ -0,0 +1,3 @@ | |||
| import { initDevTools } from './devtool'; | |||
|
|
|||
| initDevTools(); | |||
| @@ -0,0 +1,3 @@ | |||
| import { initDevTools } from './devtool'; | |||
There was a problem hiding this comment.
We will also need to add this file on the dev build right?
There was a problem hiding this comment.
Yes I think it should be opt-int by the user if the user adds
import '../src/debug';they will get support for React dev tool. do you think that there is any other better way of doing this?
There was a problem hiding this comment.
On rollup we can add this on dev bundle. and exclude it otherwise.
| const rdtHook = (window).__REACT_DEVTOOLS_GLOBAL_HOOK__; | ||
|
|
||
| // the developer has not installed react devtools | ||
| if(rdtHook == null) return; |
There was a problem hiding this comment.
when a person runs app in Development env, should we add a log recommending them to use React DevTools?
There was a problem hiding this comment.
Yes we should add that
|
@ameerthehacker Can your check if this works? |
There was a problem hiding this comment.
@ameerthehacker Also, we will have to trigger the event for component initialization, props, hooks right?
| @@ -0,0 +1,3 @@ | |||
| import { initDevTools } from './devtool'; | |||
There was a problem hiding this comment.
On rollup we can add this on dev bundle. and exclude it otherwise.
|
cool @s-yadav |
This is the WIP PR for adding react dev tools support to Brahmos
This is to address issue #65