Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libraryfied Antimatter for ES6 modules and UMD #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

remaininlight
Copy link

Thanks so much for Antimatter @dglittle and @toomim! Very, very promising

I was wanting to use it with ES6, so I used this framework to turn it into a library:
https://www.npmjs.com/package/rollup-boilerplate

Seems to work for me. Also fixed a typo on line 69.

Hope you're both good

@toomim
Copy link
Member

toomim commented Feb 2, 2022

Hey @remaininlight! Thanks for your interest in antimatter! Have I met you before? Your username looks familiar.

Making it work in ES6 modules is a great idea. This rollup-boilerplate tool sure generated a lot of code, though, and most of it is for irrelevant stuff like linting. The readme got renamed and an MIT license got added.

I like keeping the antimatter code tidy, because it's designed to be read, not just used. We are putting the algorithm on display. I think ES6 modules can be supported with a lot less code. For braidify, for instance... I basically just added this index.mjs file and this clause in package.json. I think we can do something similar for antimatter, and add ES6 module support with a scalpel.

@toomim
Copy link
Member

toomim commented Feb 2, 2022

Good catch with the typo on line 69!

@toomim
Copy link
Member

toomim commented Feb 2, 2022

Is your username @remaininlight related to the talking heads album?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants