Only run plugin tests for new or modified plugins #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschrimpf
reviewed
Jun 23, 2023
added 2 commits
June 23, 2023 08:16
mschrimpf
approved these changes
Jul 1, 2023
There was a problem hiding this comment.
looks good, but why are tests already passing now before the core changes brain-score/core#36 are even merged?
For security reasons, changes to travis.yml aren't run as part of the PR tests until it's merged to main. |
shehadak
pushed a commit
that referenced
this pull request
Aug 14, 2023
* only run plugin tests for new or modified plugins * typo * cleanup --------- Co-authored-by: Katherine Fairchild <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Depends on core PR #36]
In the interest of reducing burdensome test time, this moves from running all tests on Travis for every plugin on every PR to only running tests for plugins added or modified by the PR on Travis.
The gap in test coverage introduced by this PR is intended to be closed by instead having each PR initiate a non-blocking Jenkins run for all plugin and integration tests (possibly in conjunction with Issue #172).
Note: parse_plugin_changes.py will replace parse_changed_files.py.