Merge pull request #1141 from OCA/14.0

Syncing from upstream OCA/bank-payment (14.0)

README.md

@@ -30,7 +30,7 @@ addon | version | maintainers | summary
 [account_invoice_select_for_payment](account_invoice_select_for_payment/) | 14.0.1.0.0 |  | Account Invoice Select for Payment
 [account_payment_mode](account_payment_mode/) | 14.0.1.1.0 |  | Account Payment Mode
 [account_payment_mode_default_account](account_payment_mode_default_account/) | 14.0.1.0.0 |  | Set Receivable or Payable account according to payment mode
-[account_payment_order](account_payment_order/) | 14.0.2.5.0 |  | Account Payment Order
+[account_payment_order](account_payment_order/) | 14.0.2.5.1 |  | Account Payment Order
 [account_payment_order_grouped_output](account_payment_order_grouped_output/) | 14.0.1.0.1 |  | Account Payment Order - Generate grouped moves
 [account_payment_order_notification](account_payment_order_notification/) | 14.0.1.6.0 | [![victoralmau](https://github.com/victoralmau.png?size=30px)](https://github.com/victoralmau) | Account Payment Order Notification
 [account_payment_order_return](account_payment_order_return/) | 14.0.1.0.2 |  | Account Payment Order Return

account_payment_order/README.rst

@@ -7,7 +7,7 @@ Account Payment Order
    !! This file is generated by oca-gen-addon-readme !!
    !! changes will be overwritten.                   !!
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! source digest: sha256:5eaf546ca5154b4198d1c2a1c6edbcf8ba3d623828d297fabefef2bb80b90db5
+   !! source digest: sha256:8cb368b3078a97ff1d168b8da05209d6450ae5682b50b2d2a092b65471cf6501
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
 .. |badge1| image:: https://img.shields.io/badge/maturity-Mature-brightgreen.png

account_payment_order/__manifest__.py

@@ -8,7 +8,7 @@
 
 {
     "name": "Account Payment Order",
-    "version": "14.0.2.5.0",
+    "version": "14.0.2.5.1",
     "license": "AGPL-3",
     "author": "ACSONE SA/NV, "
     "Therp BV, "

account_payment_order/models/account_payment_order.py

@@ -163,15 +163,15 @@ class AccountPaymentOrder(models.Model):
     )
     def _compute_partner_banks_archive_msg(self):
         """Information message to show archived bank accounts and to be able
-        to act on them before confirmation."""
+        to act on them before confirmation (avoid duplicates)."""
         for item in self:
             msg_lines = []
-            for line in item.payment_line_ids.filtered(
+            for partner_bank in item.payment_line_ids.filtered(
                 lambda x: x.partner_bank_id and not x.partner_bank_id.active
-            ):
+            ).mapped("partner_bank_id"):
                 msg_line = _("<b>Account Number</b>: %s - <b>Partner</b>: %s") % (
-                    line.partner_bank_id.acc_number,
-                    line.partner_bank_id.partner_id.display_name,
+                    partner_bank.acc_number,
+                    partner_bank.partner_id.display_name,
                 )
                 msg_lines.append(msg_line)
             item.partner_banks_archive_msg = (

account_payment_order/static/description/index.html

@@ -366,7 +366,7 @@ <h1 class="title">Account Payment Order</h1>
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-!! source digest: sha256:5eaf546ca5154b4198d1c2a1c6edbcf8ba3d623828d297fabefef2bb80b90db5
+!! source digest: sha256:8cb368b3078a97ff1d168b8da05209d6450ae5682b50b2d2a092b65471cf6501
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
 <p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Mature" src="https://img.shields.io/badge/maturity-Mature-brightgreen.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/bank-payment/tree/14.0/account_payment_order"><img alt="OCA/bank-payment" src="https://img.shields.io/badge/github-OCA%2Fbank--payment-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_order"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/bank-payment&amp;target_branch=14.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module adds support for payment orders and debit orders.</p>