Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update original kim dev atlas details #280

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Update original kim dev atlas details #280

merged 3 commits into from
Feb 20, 2025

Conversation

adamltyson
Copy link
Member

@adamltyson adamltyson requested a review from PolarBean February 5, 2025 15:12
@PolarBean
Copy link
Member

all looks good but it is deeply confusing that there are two versions of kim dev v1 (or that v001 differs from v1)
especially since they are in a different space. One is MRI and one is allen but both are P56...
image

Copy link
Member

@PolarBean PolarBean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This atlas is now superseded by its 1.0.0 version

Is this true. Firstly can v001 be superseded by v1. also they are in different spaces one in allen and one in MRI space, the allen space one is very useful for alternative analysis of allen registered data. Perhaps I wouldnt say its use is for reproducibility and archive reasons.

@adamltyson
Copy link
Member Author

You're right, but we can't fix everything immediately. This at least makes the docs consistent.

We're available for help if anyone gets confused.

@PolarBean
Copy link
Member

Perhaps I should reach out to the Kim group and ask them to clarify the versioning?

@adamltyson
Copy link
Member Author

Pretty sure 001 was the original release, when they had only created the p56 templates. 1.0.0 is the "official" full, first release of all timepoints.

@PolarBean
Copy link
Member

oh yeah for sure but I could contact them to ask if they meant "0.0.1" or how they would prefer we handle this

@adamltyson
Copy link
Member Author

They've previously referred to it as "v1". You're welcome to reach out, but I'm happy to just merge this and move on.

@adamltyson
Copy link
Member Author

@PolarBean I'm going to merge this as the 001/0.0.1 question was "decided" in #284, and this at least makes everything consistent.

@adamltyson adamltyson merged commit d6f7876 into main Feb 20, 2025
3 checks passed
@adamltyson adamltyson deleted the kim-dev branch February 20, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants