-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shopper insights rp2 feature #1256
Open
warmkesselj
wants to merge
14
commits into
main
Choose a base branch
from
shopper-insights-rp2-feature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6921521
Add `isPayPalAppInstalled` and `isVenmoAppInstalled` to Shopper Insig…
sarahkoop fb4455d
Add `sessionId` to `ShopperInsightsClient` (#1230)
sarahkoop 8427bcd
Shopper insights rp1 feature include session (#1235)
warmkesselj 246f2af
Shopper insights rp1 feature sessionid analytics (#1238)
warmkesselj 026b2f5
Add Shopper Session ID param (#1241)
sarahkoop 4094144
merge main
sarahkoop f93a608
Fix merge main
sarahkoop 894fc2d
Shopper insights rp2 feature presentment details (#1244)
warmkesselj 934d2ba
Shopper insights rp2 feature selected event button (#1247)
warmkesselj 9e9a402
Remove `paymentMethodsDisplayed` (#1249)
jaxdesmarais 656f5c7
Merge branch 'main' into shopper-insights-rp1-feature
warmkesselj 02b6676
Merge branch 'shopper-insights-rp1-feature' into shopper-insights-rp2…
warmkesselj 3653334
Update changelog
warmkesselj 786b0d1
Remove optional comment
warmkesselj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,18 @@ | ||
# Braintree Android SDK Release Notes | ||
|
||
## unreleased | ||
|
||
* PayPal | ||
* Fix bug to ensure that `PayPalVaultRequest.userAuthenticationEmail` is not sent as an empty string | ||
|
||
* ShopperInsights (BETA) | ||
* Add `isPayPalAppInstalled` and `isVenmoAppInstalled` methods | ||
* Add `shopperSessionId` parameter to `ShopperInsightsClient` | ||
* BraintreePayPal | ||
* Add `shopperSessionId` to `PayPalCheckoutRequest` and `PayPalVaultRequest` | ||
* Fix bug to ensure that `PayPalVaultRequest.userAuthenticationEmail` is not sent as an empty string | ||
* Replace `sendPayPalPresentedEvent()` and `sendVenmoPresentedEvent()` with `sendPresentedEvent()` | ||
* Replace `sendPayPalSelectedEvent()` and `sendVenmoSelectedEvent()` with `sendSelectedEvent()` | ||
* ThreeDSecure | ||
* Return error if no `dfReferenceId` is returned in the 3D Secure flow | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit pick - I think the indentation is correct on the original 3DS entry and the new entries are indented too far |
||
* Return error if no `dfReferenceId` is returned in the 3D Secure flow | ||
|
||
## 5.3.0 (2024-12-11) | ||
|
||
* PayPal | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not delete this