Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move demo app publish to gh action #127

Merged
merged 6 commits into from
Feb 25, 2025
Merged

Move demo app publish to gh action #127

merged 6 commits into from
Feb 25, 2025

Conversation

CJGlitter
Copy link
Member

@CJGlitter CJGlitter commented Feb 25, 2025 •
edited
Loading

Summary

Moving post-publish steps to GH actions.

publish.yml

  • Add publish gh pages job

publish-gh-pages.yml

  • Created workflow to publish to gh-pages

package.json

  • Remove post publish script and build:app

publish-gh-pages.sh

  • DELETE

ci.yml

  • Renamed from ci-unit-tests

integration-tests.yml

  • Renamed from ci-integraton-tests

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

Reviewers

@braintree/team-sdk-js

@CJGlitter CJGlitter marked this pull request as ready for review February 25, 2025 20:06
@CJGlitter CJGlitter requested a review from a team as a code owner February 25, 2025 20:06
GoogilyBoogily
GoogilyBoogily approved these changes Feb 25, 2025
View reviewed changes
Copy link

@GoogilyBoogily GoogilyBoogily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐸

mikenichols
mikenichols approved these changes Feb 25, 2025
View reviewed changes
Copy link

@mikenichols mikenichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@CJGlitter CJGlitter merged commit 96ce5f8 into main Feb 25, 2025
2 checks passed
@CJGlitter CJGlitter deleted the move-demo-app-publish-to-gh-action branch February 25, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikenichols mikenichols mikenichols approved these changes

@GoogilyBoogily GoogilyBoogily GoogilyBoogily approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CJGlitter @mikenichols @GoogilyBoogily