Feature/pr214 Appendable to output and error streams - changes #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the default is no longer null, we can skip checking for null in run. I've backed this assumption by addition preconditions to the setters. Last: The processInputStream is actually the output stream, the code now reflects that as well.
…nges Conflicts: src/test/java/net/bramp/ffmpeg/FFmpegTest.java
…nges Conflicts: src/test/java/net/bramp/ffmpeg/FFmpegTest.java
|
Looks good. Thanks. |
This was referenced Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't (or don't know how to) edit a pr from another person.
Here are the changes from #214 as specified in the review from @bramp.
Changes:
Additionally, I've merged the current head to this branch and resolved conflicts