Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks in draw and cacheCharacters functions. #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andyschwarzl
Copy link

No description provided.

@jastrebok
Copy link

Hello, I'm asking you for help with gltext. It seems that your memory leak fix is not enough for me.

@andyschwarzl
Copy link
Author

Hello. The fix might not be complete since I only considered these two functions, which has been fine for me. Try to use valgrind and find any missing memory/buffer releases. HTH

@jastrebok
Copy link

Hello,

I managed to get the thing working with only a minimal leak (unfortunately,
something is still leaking) but I have a different problem. All characters
that reach below baseline (like g,j,p,q,y or even Q) are not displayed using
this library. Is it just in my case? I haven't tried to modify anything in
the font construction.

Petr

---------- Původní zpráva ----------

Od: Andreas Schwarzl [email protected]

Komu: branan/gltext [email protected]

Datum: 9. 3. 2015 9:32:07

Předmět: Re: [gltext] Fix memory leaks in draw and cacheCharacters
functions. (#9)

"

Hello. The fix might not be complete since I only considered these two
functions, which has been fine for me. Try to use valgrind and find any
missing memory/buffer releases. HTH

Reply to this email directly or view it on GitHub
(#9 (comment)).

"=

@ColinGilbert
Copy link

I noticed that the included version on Harbuzz is 0.7.0, have you linked against this code, or an updated version?

@jastrebok
Copy link

I don't know which version I have, unfortunately. I cannot find it in the
source files. Do you think that something changed in that respect?

I also noticed, that when the font is bigger, some other characters start to
disappear as well, mostly letters or numbers with curves (like S).

---------- Původní zpráva ----------

Od: Colin Gilbert [email protected]

Komu: branan/gltext [email protected]

Datum: 28. 3. 2015 1:39:08

Předmět: Re: [gltext] Fix memory leaks in draw and cacheCharacters
functions. (#9)

"

I noticed that the included version on Harbuzz is 0.7.0, have you linked
against this code, or an updated version?

Reply to this email directly or view it on GitHub
(#9 (comment)).

"=

@ColinGilbert
Copy link

There is at the beginning of gltext.hpp a line

#define GLTEXT_CACHE_TEXTURE_SIZE 256

Try changing that value to 512, or even 1024, then tell me what happens. Quite curious to hear your results.

@jastrebok
Copy link

Apparently, nothing changed. :(

---------- Původní zpráva ----------

Od: Colin Gilbert [email protected]

Komu: branan/gltext [email protected]

Datum: 28. 3. 2015 8:44:26

Předmět: Re: [gltext] Fix memory leaks in draw and cacheCharacters
functions. (#9)

"

There is at the begging of gltext.hpp a line

#define GLTEXT_CACHE_TEXTURE_SIZE 256

Try changing that value to 512, or even 1024, then tell me what happens.
Quite curious to hear your results.

Reply to this email directly or view it on GitHub
(#9 (comment)).

"=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants