Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/upload-artifact action to v4.4.3 #1523

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 16, 2024

This PR contains the following updates:

Package Type Update Change
actions/upload-artifact action patch v4.4.0 -> v4.4.3

Release Notes

actions/upload-artifact (actions/upload-artifact)

v4.4.3

Compare Source

What's Changed

Full Changelog: actions/upload-artifact@v4.4.2...v4.4.3

v4.4.2

Compare Source

What's Changed

Full Changelog: actions/upload-artifact@v4.4.1...v4.4.2

v4.4.1

Compare Source

What's Changed
New Contributors

Full Changelog: actions/upload-artifact@v4.4.0...v4.4.1


Configuration

📅 Schedule: Branch creation - "* 0-4 * * 3" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Oct 16, 2024
mrose17 added a commit that referenced this pull request Oct 18, 2024
Looks fine on desktop.
mrose17 added a commit that referenced this pull request Oct 18, 2024
Looks fine on desktop and `dev1`
mrose17 added a commit that referenced this pull request Oct 18, 2024
Looks good on desktop, `dev1`, and `dev2`.
@renovate renovate bot force-pushed the renovate/actions-upload-artifact-4.x branch from 46080de to b2bb600 Compare October 18, 2024 14:18
Copy link

[puLL-Merge] - actions/[email protected]

Description

This PR updates the upload-artifact action, focusing on improving its functionality and security. The changes include updating dependencies, enhancing error handling, and adding support for symlinked files.

Changes

Changes

  1. .github/workflows/publish-immutable-actions.yml:

    • Added a new workflow for publishing immutable action versions.
  2. .github/workflows/test.yml:

    • Enhanced the end-to-end test to include symlinked files.
    • Added a new test case for uploading and verifying symlinked artifacts.
  3. README.md:

    • Added a new section on uploading hidden files, explaining how to include them and exclude sensitive information.
  4. dist/merge/index.js and dist/upload/index.js:

    • Updated to reflect changes in the underlying @actions/artifact library.
    • Improved error handling for malformed zip entries.
    • Added support for symlinked files.
    • Enhanced the upload progress monitoring mechanism.
  5. package.json:

    • Updated version to 4.4.3.
    • Updated dependencies:
      • @actions/artifact to ^2.1.11
      • @actions/core to ^1.11.1

Possible Issues

The changes to the zip entry path sanitization might potentially affect existing workflows that rely on specific path structures. Users should test their workflows to ensure compatibility.

Security Hotspots

  1. The change in zip entry path sanitization (entry.path.replace(/(?<=^|[/\\]+)[.][.]+(?=[/\\]+|$)/g, ".")) improves security by preventing path traversal attacks more effectively. However, it's crucial to ensure this change doesn't introduce any unintended side effects in edge cases.

  2. The new feature for uploading hidden files could potentially lead to the accidental inclusion of sensitive data. While the README provides guidance on excluding sensitive files, users should be cautious when using this feature.

Copy link
Member

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on desktop. dev1, dev2, and dev3.

@mrose17 mrose17 merged commit 13d6f9d into main Oct 18, 2024
8 checks passed
@renovate renovate bot deleted the renovate/actions-upload-artifact-4.x branch October 18, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file puLL-Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant