Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/setup-node action to v4.1.0 #1533

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 30, 2024

This PR contains the following updates:

Package Type Update Change
actions/setup-node action minor v4.0.4 -> v4.1.0

Release Notes

actions/setup-node (actions/setup-node)

v4.1.0

Compare Source


Configuration

📅 Schedule: Branch creation - "* 0-4 * * 3" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Oct 30, 2024
Copy link

[puLL-Merge] - actions/[email protected]

Description

This PR introduces several changes to improve the caching mechanism and GHES detection in the setup-node action. The main changes include incorporating the CPU architecture into the cache key, refining the GHES detection logic, and updating dependencies.

Changes

Changes

  1. .github/workflows/publish-immutable-actions.yml:

    • Updated the trigger for the workflow from release: [created] to release: [published].
    • Updated the actions/publish-immutable-action version from 0.0.1 to 0.0.3.
    • Removed the github-token input.
  2. __tests__/cache-restore.test.ts:

    • Added os module import and mocking of os.arch() function.
    • Updated test cases to include CPU architecture in the cache key.
  3. __tests__/cache-utils.test.ts:

    • Added new test cases for the isGhes() function to cover different scenarios.
  4. __tests__/data/pnpm-lock.yaml:

    • Updated the pnpm lockfile version and dependencies.
  5. dist/cache-save/index.js and dist/setup/index.js:

    • Updated the isGhes() function to handle GitHub Enterprise Cloud and localhost scenarios.
    • Incorporated CPU architecture into the cache key generation.
  6. src/cache-restore.ts:

    • Added CPU architecture to the cache key generation.
  7. src/cache-utils.ts:

    • Refined the isGhes() function to exclude GitHub Enterprise Cloud and localhost scenarios.

Possible Issues

The changes to the GHES detection logic might affect environments that were previously incorrectly identified as GHES. It's important to test this change thoroughly in various environments to ensure correct behavior.

Security Hotspots

No significant security hotspots were identified in this change. The modifications to the GHES detection logic and cache key generation do not introduce any apparent security risks.

mrose17 added a commit that referenced this pull request Oct 31, 2024
Looks good on desktop
mrose17 added a commit that referenced this pull request Oct 31, 2024
Looks good on desktop and `dev1`.
mrose17 added a commit that referenced this pull request Oct 31, 2024
Looks good on desktop, `dev1`, and `dev2`.
Copy link
Member

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on desktop, dev1, dev2, and dev3.

@mrose17 mrose17 merged commit 8335c9c into main Oct 31, 2024
8 checks passed
@renovate renovate bot deleted the renovate/actions-setup-node-4.x branch October 31, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file puLL-Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant