add ability to specify a specific file to write results to too

[pes10k]

fixes #66

[pes10k]

i think these warnings can be safely ignored. All these uses are with arguments provided by the user, when using this as a command line too

[ShivanKaul]

I think you actually want to make the changes in run.ts, and then the build will auto-generate run.js etc. We only want to change .ts files, and we should keep ignoring built/

[pes10k]

im not sure i understand, the changes i made are in validate.ts and crawl.ts.

The reason i checked in built is so that folks can use the code w/o having to download the typescript chain. But if you'd prefer i pull it back out i can

[ShivanKaul]

Ah, do you not need any changes in run.ts? I got confused by the fact that run.js is now being built and checked in.

Yeah, I think it would be best to not check in the built JS files.

[ShivanKaul]

Everything else LGTM, just please amend the -o help text to account for this new functionality: https://github.com/brave/pagegraph-crawl/blob/main/src/run.ts#L25

[pes10k]

run.js is being checked in bc all the *.js files are checked in, but i didnt make any changes to run.ts. and okie.

Just pushed a change that keeps built out

[pes10k]

okie pushed an update that also describes the new -o behavior

[ShivanKaul]

Looks great!

[github-actions]

The following commits were not verified:
8196d31 (unknown_key)