Merge pull request #103 from break-stuff/react-bool-props

patch react boolean attributes
break-stuff · Mar 10, 2024 · bc40fe4 · bc40fe4
2 parents 6147db5 + 625c021
commit bc40fe4
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/demo/react-app/src/App.tsx b/demo/react-app/src/App.tsx
@@ -29,7 +29,7 @@ function App() {
       <p className="read-the-docs">
         Click on the Vite and React logos to learn more
       </p>
-      <RadioGroup variants="primary" complex="multi" external2="value5" external="value1">
+      <RadioGroup variants="primary" complex="multi" external2="value5" external="value1" disabled={false}>
         <RadioButton value=""></RadioButton>
         <RadioButton></RadioButton>
         <RadioButton></RadioButton>

diff --git a/packages/react-wrappers/CHANGELOG.md b/packages/react-wrappers/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 1.4.2
+
+- Fix boolean properties when setting them to `false`
+
 ## 1.4.1
 
 - Allow any string for `descriptionSrc`

diff --git a/packages/react-wrappers/package.json b/packages/react-wrappers/package.json
@@ -1,6 +1,6 @@
 {
   "name": "custom-element-react-wrappers",
-  "version": "1.4.1",
+  "version": "1.4.2",
   "description": "A tool for generating react-compatible wrappers for custom elements",
   "main": "index.js",
   "module": "index.js",

diff --git a/packages/react-wrappers/src/wrapper-generator.ts b/packages/react-wrappers/src/wrapper-generator.ts
@@ -279,7 +279,7 @@ function getEventTemplates(eventNames: EventName[]) {
 function getBooleanAttributeTemplates(booleanAttributes: MappedAttribute[]) {
   return (
     booleanAttributes?.map(
-      (attr) => `'${attr.name}': props.${attr?.propName}`
+      (attr) => `'${attr.name}': props.${attr?.propName} ? '' : undefined`
     ) || []
   );
 }