custom-element-jet-brains-integration: Improve JS property and event generation #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop using attributes to generate JS properties Allow only public and non-static CEM class fields to be converted JS properties Fix JS properties not using correct format for type
Add support for event type Stop converting events without names from the CEM
… and descriptions
break-stuff
reviewed
Mar 7, 2024
nolan-white
commented
Mar 7, 2024
break-stuff
reviewed
Mar 8, 2024
Older versions of JetBrains IDEs may still rely on the old schema, so leave this here for now
break-stuff
reviewed
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making the generator! I was bummed out when I discovered that there isn't an official Web Types generator for pure web components yet, so I appreciate the work you've put in to translate the official web components spec to Web Types.
I took a first pass at fixing some issues I found with the generation of JS properties and events on custom elements. From my manual testing, this seems to have fixed all of the issues I was having. I couldn't get the automated tests to run on my machine, so I'm not sure if those still pass with the new changes.