Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate flutter_rust_bridge from v1 to v2 #940

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

erdemyerebasmaz
Copy link
Contributor

@erdemyerebasmaz erdemyerebasmaz commented Apr 18, 2024

This PR addresses migration of flutter_rust_bridge from v1 to v2.

Changelist:

  • Cleaned up frb v1 files
  • Config settings are now read from flutter_rust_bridge.yaml configuration file bc7b6a0
  • Set 2.0.0-dev.34 as minimum version[1].

TODO:

Notes:

  1. We have a struct with a field named template, which is a reserved C++ keyword that caused issues on generation, which got addressed on 2.0.0-dev.34 hence why it's set as the minimum version. Related issue:

@erdemyerebasmaz erdemyerebasmaz changed the title Migrate flutter_rust_bridge from v1 to v2 [frb] Migrate flutter_rust_bridge from v1 to v2 May 7, 2024
@erdemyerebasmaz erdemyerebasmaz force-pushed the flutter_rust_bridge_v2 branch 2 times, most recently from 9a7b4eb to 797375d Compare May 27, 2024 15:45
@erdemyerebasmaz erdemyerebasmaz marked this pull request as ready for review May 27, 2024 18:00
@erdemyerebasmaz erdemyerebasmaz changed the title [frb] Migrate flutter_rust_bridge from v1 to v2 Migrate flutter_rust_bridge from v1 to v2 May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant