Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build core package for Linux/Windows targets #164

Merged
merged 4 commits into from
May 16, 2024
Merged

Conversation

erdemyerebasmaz
Copy link
Contributor

@erdemyerebasmaz erdemyerebasmaz commented May 6, 2024

This PR fixes issues on Linux/Windows target builds.

Changelist:

  • Only build core package for Linux/Windows targets
    • Fix filepath of target libraries
  • Add requirements to build binaries locally on README.md
  • Build binaries as part of just bootstrap recipe

Windows build is disabled temporarily as it's incompatible with macos-latest runner in it's current stage. Feel free to address it, but it's a very low priority issue.

More info here: Cross compiling from macOS to Windows - Logs

@ok300
Copy link
Contributor

ok300 commented May 8, 2024

Maybe it's worth opening a GH issue to track the Windows build issue?

@erdemyerebasmaz
Copy link
Contributor Author

Maybe it's worth opening a GH issue to track the Windows build issue?

Opened:

@erdemyerebasmaz erdemyerebasmaz removed the request for review from dangeross May 8, 2024 09:22
@ok300
Copy link
Contributor

ok300 commented May 15, 2024

@erdemyerebasmaz can you please rebase and check if this still looks good? A bigger PR was just merged.

@erdemyerebasmaz
Copy link
Contributor Author

@erdemyerebasmaz can you please rebase and check if this still looks good? A bigger PR was just merged.

Rebased on top of main and it looks good. Updated dependencies to latest on packages & made building libraries optional on just bootstrap command as we've discussed.

  • Make building libraries optional on bootstrap step e94e866
  • Update dependencies to latest 4c64525

@erdemyerebasmaz erdemyerebasmaz merged commit 94cb959 into main May 16, 2024
5 checks passed
@erdemyerebasmaz erdemyerebasmaz deleted the flutter_ci branch May 16, 2024 12:19
@erdemyerebasmaz erdemyerebasmaz restored the flutter_ci branch May 21, 2024 09:11
@erdemyerebasmaz erdemyerebasmaz deleted the flutter_ci branch May 21, 2024 09:11
erdemyerebasmaz added a commit that referenced this pull request May 22, 2024
erdemyerebasmaz added a commit that referenced this pull request May 22, 2024
erdemyerebasmaz added a commit that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants