Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Receive Chain Swap: support refund even when lockup address is re-used #471
base: main
Are you sure you want to change the base?
Receive Chain Swap: support refund even when lockup address is re-used #471
Changes from all commits
9b173e4
d2eae3f
dd0ca82
e22a5f8
6e34fee
8a325e3
fd10940
415b63e
381bbbd
d98fd07
82264e9
4d56bda
2987200
87effa5
b5cfc60
87e9327
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's my understanding that this PR fixes that the refundable swap is no longer shown in
list_refundables
. I have two questions, after executing a refund:list_payments
?My concern is the swap is no longer refundable if broadcasting the refund with too low a fee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
Only for cooperative refunds. The non-coop refunds don't have RBF enabled.
However there is no timeout after which cooperative refunds are impossible. The only way I could test non-cooperative refunds was by commenting out the coop refund call. Boltz participated in the coop refund even weeks after a swap failed.
From what I can tell, this can only happen if
IMO this is unlikely because of the 1st point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried on main branch to do this, but I get a "No UTXO found" error. Probably because the electrum script_list_unspent excludes them "Any output that is spent in the mempool does not appear"
I think Boltz will always try to cooperate with a refund (always if the lockup failed or if the swap expired after they refund themselves). So it's more doomsday handling