Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discount Confidential Transactions #637

Merged
merged 9 commits into from
Jan 19, 2025
Merged

Discount Confidential Transactions #637

merged 9 commits into from
Jan 19, 2025

Conversation

dangeross
Copy link
Collaborator

@dangeross dangeross commented Jan 3, 2025

This PR:

  • Bumps dependencies LWK 0.8.0 (* see issues), elements 0.25.0
  • Updates the secp256k1-zkp patch rebasing the original patch on 0.11.0
  • Uses Discount CT to calculate fees and takes into account the discount vsize when calculating tx sizes
  • Broadcasts txs using the confisured electrum server instead of esplora
  • Remove use of esplora to fetch txs & script history

Partially addresses #554 by using Discount-CT instead of lowball fees and removes the requirement to broadcast via the functionaries mempool.

Depends on breez/breez-sdk-greenlight#1151
Fixes #625

Issues
Currently seeing this issue initialising LWK throwing a UpdateOnDifferentStatus error, that I've added into the workaround to clear the persisted storage:

Update created on a wallet with status 4744058033684919366 while current wallet has 17512409250608082394

Looks similar to this issue, but the fix is already applied

Copy link
Contributor

@danielgranhao danielgranhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left some nit comments.

Regarding the workaround, how much of an overhead does it represent? I'm trying to understand if it's fine to ship it.

lib/core/src/chain/liquid.rs Outdated Show resolved Hide resolved
lib/core/src/chain/liquid.rs Show resolved Hide resolved
lib/core/src/wallet.rs Show resolved Hide resolved
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@roeierez roeierez modified the milestone: v0.6.0 Jan 6, 2025
@roeierez roeierez added this to the Next Release milestone Jan 9, 2025
@roeierez
Copy link
Member

@dangeross This can be merged now and we can start test it on misty.

@dangeross dangeross merged commit 746b6e0 into main Jan 19, 2025
9 checks passed
@dangeross dangeross deleted the savage-discount-ct branch January 19, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to DiscountCT by Feb 2025
4 participants