-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discount Confidential Transactions #637
Conversation
a000d75
to
63b7065
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left some nit comments.
Regarding the workaround, how much of an overhead does it represent? I'm trying to understand if it's fine to ship it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
00b2964
to
55f51bb
Compare
55f51bb
to
fadb538
Compare
fadb538
to
2f7f7b3
Compare
@dangeross This can be merged now and we can start test it on misty. |
This PR:
Partially addresses #554 by using Discount-CT instead of lowball fees and removes the requirement to broadcast via the functionaries mempool.
Depends on breez/breez-sdk-greenlight#1151
Fixes #625
Issues
Currently seeing this issue initialising LWK throwing a UpdateOnDifferentStatus error, that I've added into the workaround to clear the persisted storage:
Looks similar to this issue, but the fix is already applied