Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address iOS online build issues #135

Merged
merged 11 commits into from
Aug 20, 2024
Merged

Address iOS online build issues #135

merged 11 commits into from
Aug 20, 2024

Conversation

erdemyerebasmaz
Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz commented Aug 7, 2024 •
edited
Loading

Depends on:

This PR addresses build issues that prevented us from deploying to TestFlight and other required changes for the app to function as expected.

  • Use "macos-14" runner which targets XCode 15.4 by default
    • It is suggested to use XCode >= 15.3 to address this build error:
    Could not resolve package dependencies: Package.resolved file is corrupted or malformed; fix or delete the 
file to continue: unknown 'PinsStorage' version '3' at '/Users/runner/work/l-***/l- 
***/l***/ios/Runner.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved'.
  • Create ExportOptions.plist
  • Install Protoc when building the library
  • Add NDEF to NFC tag reader session formats
  • Use shared keychain on iOS

@erdemyerebasmaz erdemyerebasmaz force-pushed the build_ios_xcode15.4 branch 7 times, most recently from 0235cdc to 648293a Compare August 16, 2024 11:48
@erdemyerebasmaz
Use "macos-14" runner which targets XCode 15.4 by default
344cf5b 
It is suggested to use XCode >= 15.3 to address this build error:
```
Could not resolve package dependencies: Package.resolved file is corrupted or malformed; fix or delete the file to continue: unknown 'PinsStorage' version '3' at '/Users/runner/work/l-***/l-***/l***/ios/Runner.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved'.
```
@erdemyerebasmaz
Create ExportOptions.plist
59cc6eb
@erdemyerebasmaz
Install Protoc when building the library
741d783
@erdemyerebasmaz
Add NDEF to NFC tag reader session formats
2c8426b
@erdemyerebasmaz
Use shared keychain on iOS
012fff2
@erdemyerebasmaz
Update provisioning profile
a93a152 
Update ExportOptions.plist
@erdemyerebasmaz
Hardcode app group value
e021ae8
@erdemyerebasmaz
Hardcode app id prefix
e0518d3
dangeross
dangeross approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erdemyerebasmaz erdemyerebasmaz merged commit 3c18cb2 into main Aug 20, 2024
1 check passed
@erdemyerebasmaz erdemyerebasmaz deleted the build_ios_xcode15.4 branch August 20, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangeross dangeross dangeross approved these changes

@roeierez roeierez Awaiting requested review from roeierez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erdemyerebasmaz @dangeross