Improve BTC address validation on BitcoinAddressTextFormField
#145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdemyerebasmaz
force-pushed
the
btc_address_validation
branch
from
eb6b1ad to
f722c2c
Compare
Closes #144 * Remove `BitcoinAddressInfo` and rely on SDK for parsing
erdemyerebasmaz
force-pushed
the
btc_address_validation
branch
from
f722c2c to
f6c258a
Compare
dangeross
approved these changes
Aug 19, 2024
Yes, we can validate based on address type once Liquid address changes are finalized & integrated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #144
BitcoinAddressTextFormField'svalidatorBitcoinAddressInfoand rely on SDK for parsingaddIncomingInput'sbolt11param toinput