Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change parse call to SDK instance #265

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Change parse call to SDK instance #265

merged 2 commits into from
Jan 3, 2025

Conversation

dangeross
Copy link
Contributor

@dangeross dangeross commented Dec 13, 2024 •
edited
Loading

This PR:

  • adds BreezSDKLiquid to the InputCupit so we can call parse() on the SDK instance
  • adds externalInputParsers to the Config extension

CI run using breez/breez-sdk-liquid#605:
https://github.com/breez/misty-breez/actions/runs/12324221413

hydra-yse
hydra-yse approved these changes Dec 15, 2024
View reviewed changes
Copy link
Member

@hydra-yse hydra-yse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangeross dangeross merged commit ab11897 into main Jan 3, 2025
1 of 2 checks passed
@dangeross dangeross deleted the savage-parse-update branch January 3, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hydra-yse hydra-yse hydra-yse approved these changes

@danielgranhao danielgranhao danielgranhao approved these changes

@roeierez roeierez roeierez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dangeross @roeierez @danielgranhao @hydra-yse