New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip htlcs when forward_msat is missing #9

Merged

JssDWt merged 1 commit into main from jssdwt-handle-missing-forward-msat

Nov 18, 2024

Collaborator

JssDWt commented Nov 18, 2024

Lightningd was crashing because the trampoline plugin failed to deserialize htlcs.

Plugin trampoline for htlc_accepted returned non-result response {"error":{"code":-32700,"data":null,"message":"missing field `forward_msat`"},"id":"cln:htlc_accepted#98","jsonrpc":"2.0"}

Turns out any field in the onion can be undefined: https://github.com/ElementsProject/lightning/blob/bc419b41a8cde74680b829fc0c74ca30d2ad9e9e/lightningd/peer_htlcs.c#L1116-L1140

So the only remaining field in the onion is made optional in this PR.
outgoing_cltv_value was removed, as it was not used.


          skip htlcs when forward_msat is missing

fa754ba

JssDWt requested review from yaslama, roeierez, hydra-yse and dangeross

November 18, 2024 10:16

dangeross approved these changes

View reviewed changes

dangeross left a comment

LGTM

JssDWt merged commit fa754ba into main

11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet