Implement strategy A #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
The compiled container is used from the deployed cache directory (if it exists).
|
Im 👎 for this. It removes all possibility to control what's writable or not. If a user would like this, they wouldn't use this library, they would just do the 3 line change themselves. I also dont see how this is better or more performant than the current code in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #21, I started working yesterday on this. (this is why I opened the PRs for the new tests)
I have opened #31 to sort things out, I pushed my branch to illustrate.
Locally the tests are passing except the tests that try to write to the cache pools. That is expected, I haven't added any change in configuration for the cache configuration (this is what I intend to test down the road if we decide on that strategy).