Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test + support custom constructor edge case #259

Merged
merged 8 commits into from
Feb 19, 2025

Conversation

brentyi
Copy link
Owner

@brentyi brentyi commented Feb 19, 2025

Thought of another edge case when we simultaneously mix:

  • Custom constructors
  • Sequence types
  • Zero-length inputs
  • Positional arguments

Added tests + simple fix.

relevant: #257 / #258

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (fd76d72) to head (9a434d4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          28       28           
  Lines        2250     2250           
=======================================
  Hits         2247     2247           
  Misses          3        3           
Flag Coverage Δ
unittests 99.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentyi brentyi merged commit 9f991c7 into main Feb 19, 2025
15 checks passed
@brentyi brentyi deleted the brent/adversarial_positional_arguments branch February 19, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant