Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove target-dir workaround for Clippy cache issues. #1738

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

briansmith
Copy link
Owner

@briansmith briansmith self-assigned this Oct 13, 2023
@briansmith
Copy link
Owner Author

@djc Do I understand this correctly? (This is part of a project to move most of this logic from mk/clippy.sh to clippy.toml.)

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #1738 (f436ed2) into main (83719c4) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1738      +/-   ##
==========================================
+ Coverage   96.10%   96.12%   +0.02%     
==========================================
  Files         137      137              
  Lines       20548    20548              
  Branches      217      217              
==========================================
+ Hits        19747    19752       +5     
+ Misses        762      760       -2     
+ Partials       39       36       -3     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@djc
Copy link
Contributor

djc commented Oct 13, 2023

I don't recall ever having used clippy's --target-dir option, so pretty sure this isn't needed!

@briansmith briansmith merged commit 64cd0b9 into main Oct 13, 2023
134 checks passed
@briansmith briansmith deleted the b/clippy-target-dir branch October 13, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants