Rearrange warning configuration #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't warn during `cargo build` or `cargo test`, but deny them in `mk/clippy.sh` so that they are caught in CI. Limit `cargo build` warnings to things that matter during the edit/test cycle.
Codecov Report
@@ Coverage Diff @@
## main #1740 +/- ##
==========================================
+ Coverage 93.92% 96.12% +2.19%
==========================================
Files 137 137
Lines 20548 20548
Branches 217 217
==========================================
+ Hits 19299 19751 +452
+ Misses 1213 760 -453
- Partials 36 37 +1
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commits for details. The goal here is to improve the IDE and edit-test cycle experience.