Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Don't test benchmarks in test and test-features jobs. #1744

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

briansmith
Copy link
Owner

@briansmith briansmith commented Oct 14, 2023

Benchmarks require Rust 1.65 or later currently due to benchmark-only dependencies.

Also, benchmarks add a lot of downloading/build time because they have many more dependencies. So, skipping them in these jobs makes them faster.

@briansmith briansmith self-assigned this Oct 14, 2023
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Merging #1744 (0c60706) into main (ff2cc71) will decrease coverage by 0.01%.
Report is 7 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1744      +/-   ##
==========================================
- Coverage   96.10%   96.10%   -0.01%     
==========================================
  Files         137      137              
  Lines       20548    20548              
  Branches      217      217              
==========================================
- Hits        19748    19747       -1     
  Misses        762      762              
- Partials       38       39       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Benchmarks require Rust 1.65 or later currently due to benchmark-only
dependencies.

Also, benchmarks add a lot of downloading/build time because they have
many more dependencies. So, skipping them in these jobs makes them
faster.
@briansmith briansmith changed the title CI: Don't test benchmarks in test jobs. CI: Don't test benchmarks in test and test-features jobs. Oct 14, 2023
@briansmith briansmith merged commit 0f8386d into main Oct 14, 2023
@briansmith briansmith deleted the b/cargo-lock branch October 14, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant