Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add clang path for Windows ARM64 hosts #1819

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

joseluisq
Copy link
Contributor

This PR just adds a new clang path to the BUILDING.md when the host is a Windows ARM64.

It was tested by building a Rust project using ring 0.17.5 on a Windows 11 ARM64 (M1 Parallels VM) successfully.

Otherwise, I should get an error similar to the following:

ring-0.17.5\build.rs:673:9:
  failed to execute ["clang" "-O3" "--target=aarch64-pc-windows-msvc" "-ffunction-sections" "-fdata-sections" "--target=aarch64-pc-windows-msvc" "-I" "include" "-I" "C:\\Users\\joseluisq\\devel\\static-web-server\\target\\aarch64-pc-windows-msvc\\release\\build\\ring-400e2572fe09d335\\out" "-Wall" "-Wextra" "-fvisibility=hidden" "-std=c1x" "-pedantic" "-Wall" "-Wextra" "-Wbad-function-cast" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wnested-externs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wstrict-prototypes" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-g3" "-DNDEBUG" "-c" "-oC:\\Users\\joseluisq\\devel\\static-web-server\\target\\aarch64-pc-windows-msvc\\release\\build\\ring-400e2572fe09d335\\out\\aesv8-armx-win64.o" "C:\\Users\\joseluisq\\.cargo\\registry\\src\\index.crates.io-6f17d22bba15001f\\ring-0.17.5\\pregenerated\\aesv8-armx-win64.S"]: program not found

@joseluisq joseluisq changed the title Docs: Add clang path for Windows ARM64 hosts [skip ci] Docs: Add clang path for Windows ARM64 hosts Nov 24, 2023
@briansmith briansmith merged commit ae02e96 into briansmith:main Nov 24, 2023
@briansmith
Copy link
Owner

Thanks!

@briansmith
Copy link
Owner

BTW, you may be interested in rust-lang/cc-rs#882, which proposes to automate this away.

@joseluisq
Copy link
Contributor Author

BTW, you may be interested in rust-lang/cc-rs#882, which proposes to automate this away.

Thanks! I didn't know about that. That improvement should be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants