windows-sys 0.52 #1852
Merged
windows-sys 0.52 #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1852 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 136 136
Lines 20692 20692
Branches 226 226
=======================================
Hits 19867 19867
Misses 791 791
Partials 34 34 ☔ View full report in Codecov by Sentry. |
|
Thanks for the PR.
No worries, because the CI will run the tests. However, we shouldn't put "I was unable to locally test this due to the asm/C code" in the commit message because that isn't useful for people reading the history. Please amend the commit to explain why we are updating to 0.52. |
Dependency bump which keeps in line with the rest of the ecosystem and intends to de-duplicates versions within users' trees.
kayabaNerve
force-pushed
the
windows-sys-0.52
branch
from
53b8d5f to
12dbd18
Compare
|
Provided a more descriptive message. |
ErichDonGubler
added a commit
to erichdongubler-contrib/ocrs
that referenced
this pull request
Jan 3, 2024
`ocrs` currently relies on checking the `HOME` environment variable to determine where to placed cached models. Windows doesn't use this, though, so of course, it breaks. 😅 Implement the proper cross-platform logic for getting a home directory with [`home::home_dir`]. `ocrs`' current dependency tree use `windows` 0.48.0 because of the `ring` dependency via dependency on `ureq`. This PR unfortuantely also brings in `windows` 0.52.0 as a duplicate dependency. [`briansmith/ring`#1852] upgrades `ring` to use `windows` 0.52.0, and should be followed up with to remove this dep. duplication. [`briansmith/ring`#1852]: briansmith/ring#1852 [`home::home_dir`]: https://docs.rs/home/0.5.9/home/fn.home_dir.html
|
Thanks! I have tested this and merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to locally test this due to the asm/C code.
I also couldn't run the CI on this commit due to the amount of jobs the CI spawns.
I stripped the non-Windows CIs out on my master branch and the Windows CIs did pass, so I believe this is valid without any actual code edits.
See https://github.com/kayabaNerve/ring/actions/runs/7096652359 for those.