Define native word size as constant_time::Word.
#2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2097 +/- ##
==========================================
- Coverage 97.25% 97.23% -0.02%
==========================================
Files 143 143
Lines 20052 20055 +3
Branches 228 228
==========================================
- Hits 19502 19501 -1
- Misses 524 527 +3
- Partials 26 27 +1 ☔ View full report in Codecov by Sentry. |
MarijnS95
reviewed
Jan 10, 2025
| @@ -21,34 +21,20 @@ | |||
| use crate::{c, error, polyfill::ArrayFlatMap}; | |||
|
|
|||
| #[cfg(any(test, feature = "alloc"))] | |||
| use crate::bits; | |||
| use crate::{bits, constant_time, polyfill::usize_from_u32}; | |||
There was a problem hiding this comment.
Hey! When building without "alloc" feature (common when using default-features = false) the below pub const LIMB_BITS: usize = usize_from_u32(Limb::BITS); tries to use this feature = "alloc"-guarded import and fails to compile, is that intended?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.