Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polyfill: Add helper for defining error types. #2219

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Conversation

briansmith
Copy link
Owner

See commit messages for details.

@briansmith briansmith self-assigned this Jan 12, 2025
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 97.04%. Comparing base (9109475) to head (c6830a0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/polyfill/cold_error.rs 50.00% 3 Missing ⚠️
src/digest.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2219      +/-   ##
==========================================
- Coverage   97.04%   97.04%   -0.01%     
==========================================
  Files         160      161       +1     
  Lines       20391    20388       -3     
  Branches      458      458              
==========================================
- Hits        19788    19785       -3     
+ Misses        498      495       -3     
- Partials      105      108       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

No functional changes. This just reduces boilerplate, especially for future
changes.
@briansmith briansmith force-pushed the b/error-boilerplate-1 branch from 28e201f to c6830a0 Compare January 12, 2025 19:03
@briansmith briansmith merged commit 7b95153 into main Jan 12, 2025
156 of 158 checks passed
@briansmith briansmith deleted the b/error-boilerplate-1 branch January 12, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant