Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pbkdf2: Clarify error handling and panic conditions. #2222

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

briansmith
Copy link
Owner

No description provided.

@briansmith briansmith self-assigned this Jan 12, 2025
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 86.76471% with 9 lines in your changes missing coverage. Please review.

Project coverage is 97.00%. Comparing base (2985668) to head (1383b7d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/error/too_much_output_requested.rs 0.00% 5 Missing ⚠️
src/pbkdf2.rs 93.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2222      +/-   ##
==========================================
- Coverage   97.04%   97.00%   -0.04%     
==========================================
  Files         161      162       +1     
  Lines       20415    20457      +42     
  Branches      458      458              
==========================================
+ Hits        19811    19845      +34     
- Misses        495      504       +9     
+ Partials      109      108       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briansmith briansmith force-pushed the b/pbkdf2-2 branch 6 times, most recently from e8062e9 to 58932c3 Compare January 13, 2025 01:26
@briansmith briansmith merged commit 89437c6 into main Jan 13, 2025
158 of 160 checks passed
@briansmith briansmith deleted the b/pbkdf2-2 branch January 13, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant