Make it clearer that we're not passing empty slices to C code. #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2269 +/- ##
=======================================
Coverage 96.74% 96.74%
=======================================
Files 171 171
Lines 20853 20854 +1
Branches 490 490
=======================================
+ Hits 20175 20176 +1
Misses 571 571
Partials 107 107 ☔ View full report in Codecov by Sentry. |
In the future we'll make this a const assertion.
briansmith
force-pushed
the
b/clarify-slicing-to-C
branch
from
b25576a to
ac5cd9f
Compare
|
I reduced this to a single commit after merging #2272, which subsumed the poly1305 case. I will deal with other cases separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each individual commit.