arithmetic internals: Clarify evenness check for empty limbs. #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be questionable to ask if two empty slices of limbs are even, so `limbs_are_even_constant_time` should return an error in that case. Luckily, we already considered empty limbs even (see the test) and callers always return an error on empty limbs. So, nothing changes, except it is clearer that we handle empty inputs correctly. This is part of a project to clarify what happens when/if/how we pass empty slices to C.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2277 +/- ##
==========================================
- Coverage 96.75% 96.75% -0.01%
==========================================
Files 171 171
Lines 20868 20866 -2
Branches 491 490 -1
==========================================
- Hits 20191 20188 -3
- Misses 571 572 +1
Partials 106 106 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be questionable to ask if two empty slices of limbs are even, so
limbs_are_even_constant_timeshould return an error in that case. Luckily, we already considered empty limbs even (see the test) and callers always return an error on empty limbs. So, nothing changes, except it is clearer that we handle empty inputs correctly.This is part of a project to clarify what happens when/if/how we pass empty slices to C.