arithmetic internals: Iterate over slice in Rust for even/zero checks. #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansmith
force-pushed
the
b/limbs-size_t
branch
from
bbedfd2 to
da0340b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2279 +/- ##
=======================================
Coverage 96.75% 96.76%
=======================================
Files 171 171
Lines 20873 20867 -6
Branches 488 487 -1
=======================================
- Hits 20195 20191 -4
+ Misses 573 572 -1
+ Partials 105 104 -1 ☔ View full report in Codecov by Sentry. |
briansmith
force-pushed
the
b/limbs-size_t
branch
2 times, most recently
from
8490c7e to
5bc94d2
Compare
(We still need `LIMBS_are_zero` because it is used from C code. Rewrite it to use the same algorithm as the Rust equivalent.) This eliminates a pair of calls to pointer-taking C functions.
briansmith
force-pushed
the
b/limbs-size_t
branch
from
5bc94d2 to
07b4194
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.