arithmetic: Clarify memory safety aspects of AliasingSlices & rename to AliasingSlices3
#2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2291 +/- ##
==========================================
- Coverage 96.76% 96.74% -0.02%
==========================================
Files 173 173
Lines 20872 20885 +13
Branches 487 487
==========================================
+ Hits 20196 20205 +9
- Misses 575 578 +3
- Partials 101 102 +1 ☔ View full report in Codecov by Sentry. |
Prepare to introduce an `AliasingSlices2` that works similarly but with one less argument.
Rename `AliasingSlices3` method to clarify how the dangling pointer aspect. Add a new helper to it that helps users avoid dangling pointers.
briansmith
force-pushed
the
b/aliasing-slices-3
branch
from
95b2255 to
e109dc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each individual commit for details.