return err in read_compressed instead of panicking #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are several others, most due to EOF in BitReader. It'll be a slightly larger effort to safely handle it all, especially as I might be replacing the BitReader implementation, but that can't really start until the 0.3 changes are more done. This one still counts though, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to address #4
At first I attempted to reconstruct a panicking input, but it was a lot of trouble so I just ended up returning the Err instead of unwrapping. The panic would only have happened if the actual uncompressed size does not match the indicated uncompressed size. I'm unfamiliar with zlib and brs so if it is more complicated than this please let me know.